| Message ID | 20230210100131.3088240-8-jiri@resnulli.us (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6b4bfa43ce29165fb0a2a8ef770d94c1d93e5ad8 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | devlink: params cleanups and devl_param_driverinit_value_get() fix | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 2 this patch: 2 |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/build_clang | success | Errors and warnings before: 1 this patch: 1 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 2 this patch: 2 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On 2/10/2023 2:01 AM, Jiri Pirko wrote: > From: Jiri Pirko <jiri@nvidia.com> > > Driver calling devl_param_driverinit_value_set() has to hold devlink > instance lock while doing that. Put an assertion there. > > Signed-off-by: Jiri Pirko <jiri@nvidia.com> > Reviewed-by: Simon Horman <simon.horman@corigine.com> > Acked-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > --- > net/devlink/leftover.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c > index 9f0256c2c323..38cdbc2039dd 100644 > --- a/net/devlink/leftover.c > +++ b/net/devlink/leftover.c > @@ -9682,6 +9682,8 @@ void devl_param_driverinit_value_set(struct devlink *devlink, u32 param_id, > { > struct devlink_param_item *param_item; > > + devl_assert_locked(devlink); > + > param_item = devlink_param_find_by_id(&devlink->params, param_id); > if (WARN_ON(!param_item)) > return;
diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c index 9f0256c2c323..38cdbc2039dd 100644 --- a/net/devlink/leftover.c +++ b/net/devlink/leftover.c @@ -9682,6 +9682,8 @@ void devl_param_driverinit_value_set(struct devlink *devlink, u32 param_id, { struct devlink_param_item *param_item; + devl_assert_locked(devlink); + param_item = devlink_param_find_by_id(&devlink->params, param_id); if (WARN_ON(!param_item)) return;