| Message ID | 20230215032122.417515-1-awkrail01@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | BPF |
| Headers | show |
| Series | [v2] fixed typos on selftests/bpf | expand |
On 2/14/23 19:21, Taichi Nishimura wrote: > Hi Randy, > > Thank you for your reviewing. > I fixed costant and it's to constant and its, respectively. > > Best regards, > Taichi Nishimura > > Signed-off-by: Taichi Nishimura <awkrail01@gmail.com> Looks good. Thanks. Acked-by: Randy Dunlap <rdunlap@infradead.org> > --- > tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/bpf/progs/test_cls_redirect.c b/tools/testing/selftests/bpf/progs/test_cls_redirect.c > index a8ba39848bbf..66b304982245 100644 > --- a/tools/testing/selftests/bpf/progs/test_cls_redirect.c > +++ b/tools/testing/selftests/bpf/progs/test_cls_redirect.c > @@ -610,8 +610,8 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap, > * > * fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321) > * > - * clang will substitute a costant for sizeof, which allows the verifier > - * to track it's value. Based on this, it can figure out the constant > + * clang will substitute a constant for sizeof, which allows the verifier > + * to track its value. Based on this, it can figure out the constant > * return value, and calling code works while still being "generic" to > * IPv4 and IPv6. > */
On 2/14/23 7:21 PM, Taichi Nishimura wrote: > Hi Randy, > > Thank you for your reviewing. > I fixed costant and it's to constant and its, respectively. > > Best regards, > Taichi Nishimura > > Signed-off-by: Taichi Nishimura <awkrail01@gmail.com> > --- > tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/bpf/progs/test_cls_redirect.c b/tools/testing/selftests/bpf/progs/test_cls_redirect.c > index a8ba39848bbf..66b304982245 100644 > --- a/tools/testing/selftests/bpf/progs/test_cls_redirect.c > +++ b/tools/testing/selftests/bpf/progs/test_cls_redirect.c > @@ -610,8 +610,8 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap, > * > * fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321) > * > - * clang will substitute a costant for sizeof, which allows the verifier > - * to track it's value. Based on this, it can figure out the constant > + * clang will substitute a constant for sizeof, which allows the verifier > + * to track its value. Based on this, it can figure out the constant This does not apply. Ensure the diff is generated by git, and against the bpf-next tree. Please include everything in v1 also, resubmit and tag for bpf-next in the subject.
diff --git a/tools/testing/selftests/bpf/progs/test_cls_redirect.c b/tools/testing/selftests/bpf/progs/test_cls_redirect.c index a8ba39848bbf..66b304982245 100644 --- a/tools/testing/selftests/bpf/progs/test_cls_redirect.c +++ b/tools/testing/selftests/bpf/progs/test_cls_redirect.c @@ -610,8 +610,8 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap, * * fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321) * - * clang will substitute a costant for sizeof, which allows the verifier - * to track it's value. Based on this, it can figure out the constant + * clang will substitute a constant for sizeof, which allows the verifier + * to track its value. Based on this, it can figure out the constant * return value, and calling code works while still being "generic" to * IPv4 and IPv6. */
Hi Randy, Thank you for your reviewing. I fixed costant and it's to constant and its, respectively. Best regards, Taichi Nishimura Signed-off-by: Taichi Nishimura <awkrail01@gmail.com> --- tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)