diff mbox series

[v2,2/2] net: phy: at803x: remove set/get wol callbacks for AR8032

Message ID 20230221231411.7786-2-leoyang.li@nxp.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series [v2,1/2] net: phy: at803x: fix the wol setting functions | expand

Checks

Context Check Description
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers fail 1 blamed authors not CCed: mail@david-bauer.net; 3 maintainers not CCed: edumazet@google.com pabeni@redhat.com mail@david-bauer.net
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Leo Li Feb. 21, 2023, 11:14 p.m. UTC
Since the AR8032 part does not support wol, remove related callbacks
from it.

Fixes: 5800091a2061 ("net: phy: at803x: add support for AR8032 PHY")
Signed-off-by: Li Yang <leoyang.li@nxp.com>
---
 drivers/net/phy/at803x.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Jakub Kicinski Feb. 24, 2023, 3:05 a.m. UTC | #1
On Tue, 21 Feb 2023 17:14:11 -0600 Li Yang wrote:
> Since the AR8032 part does not support wol, remove related callbacks
> from it.
> 
> Fixes: 5800091a2061 ("net: phy: at803x: add support for AR8032 PHY")

Is there a reason you didn't CC David Bauer <mail@david-bauer.net>,
the author of the change under Fixes? If no please repost and add him.
diff mbox series

Patch

diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 2102279b3964..ac47a1d681b2 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -2079,8 +2079,6 @@  static struct phy_driver at803x_driver[] = {
 	.flags			= PHY_POLL_CABLE_TEST,
 	.config_init		= at803x_config_init,
 	.link_change_notify	= at803x_link_change_notify,
-	.set_wol		= at803x_set_wol,
-	.get_wol		= at803x_get_wol,
 	.suspend		= at803x_suspend,
 	.resume			= at803x_resume,
 	/* PHY_BASIC_FEATURES */