| Message ID | 20230227130535.2828181-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: lan743x: LAN743X selects FIXED_PHY to resolve a link error | expand |
Hello, On Mon, 2023-02-27 at 08:05 -0500, Tom Rix wrote: > A rand config causes this link error > drivers/net/ethernet/microchip/lan743x_main.o: In function `lan743x_netdev_open': > drivers/net/ethernet/microchip/lan743x_main.c:1512: undefined reference to `fixed_phy_register' > > lan743x_netdev_open is controlled by LAN743X > fixed_phy_register is controlled by FIXED_PHY > > and the error happens when > CONFIG_LAN743X=y > CONFIG_FIXED_PHY=m > > So LAN743X should also select FIXED_PHY > > Signed-off-by: Tom Rix <trix@redhat.com> You are targeting the -net tree, but this lacks a 'Fixes' tag, please post a new version with such info. If instead the intended target was net-next (as I think it was agreed on previous revision) please repost after that net-next re-opens (in ~1w from now). Thanks, Paolo
diff --git a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig index 24c994baad13..43ba71e82260 100644 --- a/drivers/net/ethernet/microchip/Kconfig +++ b/drivers/net/ethernet/microchip/Kconfig @@ -47,6 +47,7 @@ config LAN743X depends on PCI depends on PTP_1588_CLOCK_OPTIONAL select PHYLIB + select FIXED_PHY select CRC16 select CRC32 help
A rand config causes this link error drivers/net/ethernet/microchip/lan743x_main.o: In function `lan743x_netdev_open': drivers/net/ethernet/microchip/lan743x_main.c:1512: undefined reference to `fixed_phy_register' lan743x_netdev_open is controlled by LAN743X fixed_phy_register is controlled by FIXED_PHY and the error happens when CONFIG_LAN743X=y CONFIG_FIXED_PHY=m So LAN743X should also select FIXED_PHY Signed-off-by: Tom Rix <trix@redhat.com> --- v2: Add config setting that trigger the error to commit log --- drivers/net/ethernet/microchip/Kconfig | 1 + 1 file changed, 1 insertion(+)