From patchwork Tue Mar 7 13:32:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kristian Overskeid X-Patchwork-Id: 13163525 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15580C678D4 for ; Tue, 7 Mar 2023 13:33:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229651AbjCGNdc (ORCPT ); Tue, 7 Mar 2023 08:33:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230198AbjCGNd2 (ORCPT ); Tue, 7 Mar 2023 08:33:28 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3337A241D3 for ; Tue, 7 Mar 2023 05:33:26 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id m6so17080316lfq.5 for ; Tue, 07 Mar 2023 05:33:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678196004; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6i3TQ7dgfshYjVByUVnvqz197G1zfKW2kbPj/QF4oFw=; b=JrvN5qYfPRqTHJgUv10lLMyNqUQFutOU59fh6DcjCJfkr4eGqlYheWN+CjmOGwdXjy 5uEvAHonWi//IV0gTn0YNQWUMYkv57h62Q1B/bYq4iH/pbEziLGwYXnraD9uVh+lBA9G WpM7fDoTDzn2fVyBqxtMXgiu8xfuMQ79GSwbEdNT6OSbk465jJImRM4Ha/4xgc0cV7vV /YOlsSiTRbRN5t3LJXEFWe0B2KUWA6UuYPf4OTZUyVHJBW+I5atFdTnTRnXMuRXW7xg7 jgbG1jBRZygrnAwb7EkSFzTtvCeaEdprOE4BSNBHbFNAoU1YzNmGfoXYDe3JDyQh7Ogq BzBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678196004; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6i3TQ7dgfshYjVByUVnvqz197G1zfKW2kbPj/QF4oFw=; b=Besl39Mw6LNbsbpj0jEpYY/5Dd9XevnbLnn27fbpeHj2Hd6k1wafrutlGSQk7pxSFR 5lP2X/F7CfJKlfXcy9mqS3Bon1Oqc75ooGlMG8vrna5mtDO5Y5730N70LGeZrAQaTaTF 9Q2pWZm7A2WyyKwThE8EZeSeH8lKNdRd7K6nllo2KwKHzzUfpbSQZqtQa2b31wdrGHhC /3oK4/l5ii34jjRFRC+SMBXh8uMI9AFgU30LoXaTgcaCeAlQYc2lZklfEGPoU0MZv3R7 Pm3pQHgG2qeJ2GL/Bn1q62Trh21OitKtUhoSbsWKTNAJPh83WKms7ji6AeQ0TcboctlF tMmQ== X-Gm-Message-State: AO0yUKUJO7jNzl30Yyu/7DVoCBLgM29TYk5tce1equ2N+3N+yd/dIiX8 Fg1+9ALT2EzNJLmRbgW1AbND4PuLml+fTg== X-Google-Smtp-Source: AK7set8d/WVr0drDGR9yIxhcnsiSQZ9lw4jd5d/MmIkuE7rABPTUdC/G7REjtXpu7ZR6sfMzIs5W6Q== X-Received: by 2002:ac2:532b:0:b0:4dd:af74:fe1a with SMTP id f11-20020ac2532b000000b004ddaf74fe1amr3868102lfh.48.1678196003905; Tue, 07 Mar 2023 05:33:23 -0800 (PST) Received: from oss-build.. (3peqmh0.ip.hatteland.com. [46.250.209.192]) by smtp.gmail.com with ESMTPSA id d6-20020ac241c6000000b004d575f56227sm2029652lfi.114.2023.03.07.05.33.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 05:33:23 -0800 (PST) From: Kristian Overskeid To: netdev@vger.kernel.org Cc: Kristian Overskeid Subject: [PATCH] net: hsr: Don't log netdev_err message on unknown prp dst node Date: Tue, 7 Mar 2023 14:32:29 +0100 Message-Id: <20230307133229.127442-1-koverskeid@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org If no frames has been exchanged with a node for HSR_NODE_FORGET_TIME, the node will be deleted from the node_db list. If a frame is sent to the node after it is deleted, a netdev_err message for each slave interface is produced. This should not happen with dan nodes because of supervision frames, but can happen often with san nodes, which clutters the kernel log. Since the hsr protocol does not support sans, this is only relevant for the prp protocol. Signed-off-by: Kristian Overskeid --- net/hsr/hsr_framereg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c index 00db74d96583..865eda39d601 100644 --- a/net/hsr/hsr_framereg.c +++ b/net/hsr/hsr_framereg.c @@ -415,7 +415,7 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb, node_dst = find_node_by_addr_A(&port->hsr->node_db, eth_hdr(skb)->h_dest); if (!node_dst) { - if (net_ratelimit()) + if (net_ratelimit() && port->hsr->prot_version != PRP_V1) netdev_err(skb->dev, "%s: Unknown node\n", __func__); return; }