From patchwork Tue Mar 7 18:19:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 13164447 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFF6C76186 for ; Tue, 7 Mar 2023 18:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232981AbjCGS1g (ORCPT ); Tue, 7 Mar 2023 13:27:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232900AbjCGS0B (ORCPT ); Tue, 7 Mar 2023 13:26:01 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2F1DA92EF; Tue, 7 Mar 2023 10:20:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 875A6B819C5; Tue, 7 Mar 2023 18:20:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19035C4339E; Tue, 7 Mar 2023 18:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678213228; bh=PO6YJGQP/E2abwSNE1uA5K3WGNLi+m5nTKH5md2eNqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qCkGvFlev3wtOuj6vmcxP/ryEytiA8D4qpywAn0hCDzUoVADw7OotaO+NXtxiuJoO 6Hc/0Cq2RAU+xrZ3KyB2mA+/zUQ9SIiPUNC24KU7xjXTQYMmnbeK3S25uw5vO8DnZC paJ3+7y2igLXwYlRYNtTLwbOMYdNLtwgbwABxekov0F+JSaB4BjqjRYRZ0iOhaIAQm lv10wxYE3C18AG8C+v6kaE13zqvozBT7riwL8lSyY5dVOe+BLHnWQFR5/qq4ojwhv4 zsthNfxMqY7/dyU3O1MYPosqjqjihO3Wn70d3CzPGJHpgWGbi4pWgMGs3oJh+1cMWE zQVXpTayVzqyQ== From: Bjorn Helgaas To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Edward Cree , Martin Habets Subject: [PATCH 17/28] sfc/siena: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 12:19:28 -0600 Message-Id: <20230307181940.868828-18-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307181940.868828-1-helgaas@kernel.org> References: <20230307181940.868828-1-helgaas@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Also remove the corresponding pci_disable_pcie_error_reporting() from the driver .remove() path. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas Cc: Edward Cree Cc: Martin Habets Acked-by: Edward Cree --- drivers/net/ethernet/sfc/siena/efx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/sfc/siena/efx.c b/drivers/net/ethernet/sfc/siena/efx.c index ef52ec71d197..8c557f6a183c 100644 --- a/drivers/net/ethernet/sfc/siena/efx.c +++ b/drivers/net/ethernet/sfc/siena/efx.c @@ -18,7 +18,6 @@ #include #include #include -#include #include #include "net_driver.h" #include @@ -874,8 +873,6 @@ static void efx_pci_remove(struct pci_dev *pci_dev) efx_siena_fini_struct(efx); free_netdev(efx->net_dev); - - pci_disable_pcie_error_reporting(pci_dev); }; /* NIC VPD information @@ -1094,8 +1091,6 @@ static int efx_pci_probe(struct pci_dev *pci_dev, netif_warn(efx, probe, efx->net_dev, "failed to create MTDs (%d)\n", rc); - (void)pci_enable_pcie_error_reporting(pci_dev); - if (efx->type->udp_tnl_push_ports) efx->type->udp_tnl_push_ports(efx);