| Message ID | 20230309092302.179586-1-koverskeid@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4821c186b9c343760a293b455b603735291a7865 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: hsr: Don't log netdev_err message on unknown prp dst node | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 9 Mar 2023 10:23:02 +0100 you wrote: > If no frames has been exchanged with a node for HSR_NODE_FORGET_TIME, the > node will be deleted from the node_db list. If a frame is sent to the node > after it is deleted, a netdev_err message for each slave interface is > produced. This should not happen with dan nodes because of supervision > frames, but can happen often with san nodes, which clutters the kernel > log. Since the hsr protocol does not support sans, this is only relevant > for the prp protocol. > > [...] Here is the summary with links: - [v2] net: hsr: Don't log netdev_err message on unknown prp dst node https://git.kernel.org/netdev/net-next/c/4821c186b9c3 You are awesome, thank you!
diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c index 00db74d96583..b77f1189d19d 100644 --- a/net/hsr/hsr_framereg.c +++ b/net/hsr/hsr_framereg.c @@ -415,7 +415,7 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb, node_dst = find_node_by_addr_A(&port->hsr->node_db, eth_hdr(skb)->h_dest); if (!node_dst) { - if (net_ratelimit()) + if (port->hsr->prot_version != PRP_V1 && net_ratelimit()) netdev_err(skb->dev, "%s: Unknown node\n", __func__); return; }
If no frames has been exchanged with a node for HSR_NODE_FORGET_TIME, the node will be deleted from the node_db list. If a frame is sent to the node after it is deleted, a netdev_err message for each slave interface is produced. This should not happen with dan nodes because of supervision frames, but can happen often with san nodes, which clutters the kernel log. Since the hsr protocol does not support sans, this is only relevant for the prp protocol. Signed-off-by: Kristian Overskeid <koverskeid@gmail.com> --- V1 -> V2: Addressed review comments net/hsr/hsr_framereg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)