| Message ID | 20230309100111.1246214-1-radu-nicolae.pirea@oss.nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8ba572052a4b8fe5b205854d27e54e3486049b71 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: phy: nxp-c45-tja11xx: fix MII_BASIC_CONFIG_REV bit | expand |
On Thu, Mar 09, 2023 at 12:01:11PM +0200, Radu Pirea (OSS) wrote: > According to the TJA1103 user manual, the bit for the reversed role in MII > or RMII modes is bit 4. > > Cc: <stable@vger.kernel.org> # 5.15+ I think this should include: Fixes: b050f2f15e04 ("phy: nxp-c45: add driver for tja1103") > Signed-off-by: Radu Pirea (OSS) <radu-nicolae.pirea@oss.nxp.com> > --- > drivers/net/phy/nxp-c45-tja11xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c > index 047c581457e3..5813b07242ce 100644 > --- a/drivers/net/phy/nxp-c45-tja11xx.c > +++ b/drivers/net/phy/nxp-c45-tja11xx.c > @@ -79,7 +79,7 @@ > #define SGMII_ABILITY BIT(0) > > #define VEND1_MII_BASIC_CONFIG 0xAFC6 > -#define MII_BASIC_CONFIG_REV BIT(8) > +#define MII_BASIC_CONFIG_REV BIT(4) > #define MII_BASIC_CONFIG_SGMII 0x9 > #define MII_BASIC_CONFIG_RGMII 0x7 > #define MII_BASIC_CONFIG_RMII 0x5 > -- > 2.34.1 >
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 9 Mar 2023 12:01:11 +0200 you wrote: > According to the TJA1103 user manual, the bit for the reversed role in MII > or RMII modes is bit 4. > > Cc: <stable@vger.kernel.org> # 5.15+ > Signed-off-by: Radu Pirea (OSS) <radu-nicolae.pirea@oss.nxp.com> > --- > drivers/net/phy/nxp-c45-tja11xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net] net: phy: nxp-c45-tja11xx: fix MII_BASIC_CONFIG_REV bit https://git.kernel.org/netdev/net/c/8ba572052a4b You are awesome, thank you!
diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c index 047c581457e3..5813b07242ce 100644 --- a/drivers/net/phy/nxp-c45-tja11xx.c +++ b/drivers/net/phy/nxp-c45-tja11xx.c @@ -79,7 +79,7 @@ #define SGMII_ABILITY BIT(0) #define VEND1_MII_BASIC_CONFIG 0xAFC6 -#define MII_BASIC_CONFIG_REV BIT(8) +#define MII_BASIC_CONFIG_REV BIT(4) #define MII_BASIC_CONFIG_SGMII 0x9 #define MII_BASIC_CONFIG_RGMII 0x7 #define MII_BASIC_CONFIG_RMII 0x5
According to the TJA1103 user manual, the bit for the reversed role in MII or RMII modes is bit 4. Cc: <stable@vger.kernel.org> # 5.15+ Signed-off-by: Radu Pirea (OSS) <radu-nicolae.pirea@oss.nxp.com> --- drivers/net/phy/nxp-c45-tja11xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)