diff mbox series

[net,2/2] net/smc: Fix device de-init sequence

Message ID 20230313100829.13136-3-wenjia@linux.ibm.com (mailing list archive)
State Accepted
Commit 9d876d3ef27fa84355597ad269939772192356d8
Delegated to: Netdev Maintainers
Headers show
Series net/smc: Fixes 2023-03-01 | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 18 this patch: 18
netdev/cc_maintainers success CCed 9 of 9 maintainers
netdev/build_clang success Errors and warnings before: 18 this patch: 18
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 18 this patch: 18
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Wenjia Zhang March 13, 2023, 10:08 a.m. UTC
From: Stefan Raspl <raspl@linux.ibm.com>

CLC message initialization was not properly reversed in error handling path.

Reported-and-suggested-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Stefan Raspl <raspl@linux.ibm.com>
Signed-off-by: Wenjia Zhang <wenjia@linux.ibm.com>
---
 net/smc/af_smc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Tony Lu March 13, 2023, 11:15 a.m. UTC | #1
On Mon, Mar 13, 2023 at 11:08:29AM +0100, Wenjia Zhang wrote:
> From: Stefan Raspl <raspl@linux.ibm.com>
> 
> CLC message initialization was not properly reversed in error handling path.
> 
> Reported-and-suggested-by: Alexander Gordeev <agordeev@linux.ibm.com>
> Signed-off-by: Stefan Raspl <raspl@linux.ibm.com>
> Signed-off-by: Wenjia Zhang <wenjia@linux.ibm.com>

Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>

Thanks, LGTM.

> ---
>  net/smc/af_smc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index a4cccdfdc00a..50052f53a1dd 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -3498,6 +3498,7 @@ static int __init smc_init(void)
>  out_nl:
>  	smc_nl_exit();
>  out_ism:
> +	smc_clc_exit();
>  	smc_ism_exit();
>  out_pernet_subsys_stat:
>  	unregister_pernet_subsys(&smc_net_stat_ops);
> -- 
> 2.37.2
diff mbox series

Patch

diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index a4cccdfdc00a..50052f53a1dd 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -3498,6 +3498,7 @@  static int __init smc_init(void)
 out_nl:
 	smc_nl_exit();
 out_ism:
+	smc_clc_exit();
 	smc_ism_exit();
 out_pernet_subsys_stat:
 	unregister_pernet_subsys(&smc_net_stat_ops);