| Message ID | 20230314070449.1533298-1-liuhangbin@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | [iproute2,1/2] Revert "tc: m_action: fix parsing of TCA_EXT_WARN_MSG" | expand |
On Tue, Mar 14, 2023 at 03:04:49PM +0800, Hangbin Liu wrote: > This reverts commit 70b9ebae63ce7e6f9911bdfbcf47a6d18f24159a. > > The TCA_EXT_WARN_MSG is not sit within the TCA_ACT_TAB hierarchy. It's > belong to the TCA_MAX namespace. I will fix the issue in another patch. > > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > --- > tc/m_action.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tc/m_action.c b/tc/m_action.c > index 6c91af2c..0400132c 100644 > --- a/tc/m_action.c > +++ b/tc/m_action.c > @@ -586,7 +586,7 @@ int print_action(struct nlmsghdr *n, void *arg) > > open_json_object(NULL); > tc_dump_action(fp, tb[TCA_ACT_TAB], tot_acts ? *tot_acts:0, false); > - print_ext_msg(&tb[TCA_ACT_TAB]); > + print_ext_msg(tb); > close_json_object(); > > return 0; > -- > 2.38.1 > As this patchset misses the cover letter, this covers patch 2/2 as well. Reviewed-by: Andrea Claudi <aclaudi@redhat.com>
On Tue, 14 Mar 2023 15:04:49 +0800 Hangbin Liu wrote: > This reverts commit 70b9ebae63ce7e6f9911bdfbcf47a6d18f24159a. > > The TCA_EXT_WARN_MSG is not sit within the TCA_ACT_TAB hierarchy. It's > belong to the TCA_MAX namespace. I will fix the issue in another patch. > > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> Double check the posting format if it's not just a slip up: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#co-posting-changes-to-user-space-components
On Wed, Mar 15, 2023 at 12:46:45AM -0700, Jakub Kicinski wrote: > On Tue, 14 Mar 2023 15:04:49 +0800 Hangbin Liu wrote: > > This reverts commit 70b9ebae63ce7e6f9911bdfbcf47a6d18f24159a. > > > > The TCA_EXT_WARN_MSG is not sit within the TCA_ACT_TAB hierarchy. It's > > belong to the TCA_MAX namespace. I will fix the issue in another patch. > > > > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > > Double check the posting format if it's not just a slip up: > https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#co-posting-changes-to-user-space-components Thanks, I will take care of this in the future. Hangbin
diff --git a/tc/m_action.c b/tc/m_action.c index 6c91af2c..0400132c 100644 --- a/tc/m_action.c +++ b/tc/m_action.c @@ -586,7 +586,7 @@ int print_action(struct nlmsghdr *n, void *arg) open_json_object(NULL); tc_dump_action(fp, tb[TCA_ACT_TAB], tot_acts ? *tot_acts:0, false); - print_ext_msg(&tb[TCA_ACT_TAB]); + print_ext_msg(tb); close_json_object(); return 0;
This reverts commit 70b9ebae63ce7e6f9911bdfbcf47a6d18f24159a. The TCA_EXT_WARN_MSG is not sit within the TCA_ACT_TAB hierarchy. It's belong to the TCA_MAX namespace. I will fix the issue in another patch. Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> --- tc/m_action.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)