| Message ID | 20230314131443.46342-5-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: set 'mac_managed_pm' at probe time | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Posting correctly formatted |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/fixes_present | success | Fixes tag present in non-next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 18 this patch: 18 |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/build_clang | success | Errors and warnings before: 18 this patch: 18 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 18 this patch: 18 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
Hi Wolfram, On Tue, Mar 14, 2023 at 2:30 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > On Renesas hardware, we had issues because the above flag was set during > 'open'. It was concluded that it needs to be set during 'probe'. It > looks like SMS911x needs the same fix but I can't test it because I > don't have the hardware. At least, leave a note about the issue. You no longer have the APE6-EVM? Gr{oetje,eeting}s, Geert
> > On Renesas hardware, we had issues because the above flag was set during > > 'open'. It was concluded that it needs to be set during 'probe'. It > > looks like SMS911x needs the same fix but I can't test it because I > > don't have the hardware. At least, leave a note about the issue. > > You no longer have the APE6-EVM? I should have it somewhere. Cool, thanks for the pointer!
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c index a2e511912e6a..745e0180eb34 100644 --- a/drivers/net/ethernet/smsc/smsc911x.c +++ b/drivers/net/ethernet/smsc/smsc911x.c @@ -1038,6 +1038,7 @@ static int smsc911x_mii_probe(struct net_device *dev) } /* Indicate that the MAC is responsible for managing PHY PM */ + /* FIXME: should be set right after mdiobus is registered */ phydev->mac_managed_pm = true; phy_attached_info(phydev);
On Renesas hardware, we had issues because the above flag was set during 'open'. It was concluded that it needs to be set during 'probe'. It looks like SMS911x needs the same fix but I can't test it because I don't have the hardware. At least, leave a note about the issue. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/net/ethernet/smsc/smsc911x.c | 1 + 1 file changed, 1 insertion(+)