| Message ID | 20230316043714.24279-5-samin.guo@starfivetech.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add Ethernet driver for StarFive JH7110 SoC | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
On 16/03/2023 05:37, Samin Guo wrote: > From: Yanhong Wang <yanhong.wang@starfivetech.com> > > Add documentation to describe StarFive dwmac driver(GMAC). > Thank you for your patch. There is something to discuss/improve. > Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com> > Signed-off-by: Samin Guo <samin.guo@starfivetech.com> > Tested-by: Tommaso Merciai <tomm.merciai@gmail.com> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > .../bindings/net/starfive,jh7110-dwmac.yaml | 130 ++++++++++++++++++ > MAINTAINERS | 6 + > 3 files changed, 137 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index e4519cf722ab..245f7d713261 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -91,6 +91,7 @@ properties: > - snps,dwmac-5.20 > - snps,dwxgmac > - snps,dwxgmac-2.10 > + - starfive,jh7110-dwmac > > reg: > minItems: 1 > diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > new file mode 100644 > index 000000000000..b59e6bd8201f > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > @@ -0,0 +1,130 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 StarFive Technology Co., Ltd. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH7110 DWMAC glue layer > + > +maintainers: > + - Emil Renner Berthing <kernel@esmil.dk> > + - Samin Guo <samin.guo@starfivetech.com> > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - starfive,jh7110-dwmac > + required: > + - compatible > + > +properties: > + compatible: > + items: > + - enum: > + - starfive,jh7110-dwmac > + - const: snps,dwmac-5.20 > + reg: maxItems: 1 > + clocks: > + items: > + - description: GMAC main clock > + - description: GMAC AHB clock > + - description: PTP clock > + - description: TX clock > + - description: GTX clock > + > + clock-names: > + items: > + - const: stmmaceth > + - const: pclk > + - const: ptp_ref > + - const: tx > + - const: gtx > + interrupts: ??? > + resets: > + items: > + - description: MAC Reset signal. > + - description: AHB Reset signal. > + > + reset-names: > + items: > + - const: stmmaceth > + - const: ahb > + > + starfive,tx-use-rgmii-clk: > + description: > + Tx clock is provided by external rgmii clock. > + type: boolean > + > + starfive,syscon: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - items: > + - description: phandle to syscon that configures phy mode > + - description: Offset of phy mode selection > + - description: Shift of phy mode selection > + description: > + A phandle to syscon with two arguments that configure phy mode. > + The argument one is the offset of phy mode selection, the > + argument two is the shift of phy mode selection. > + > +allOf: > + - $ref: snps,dwmac.yaml# > + > +unevaluatedProperties: false > + Best regards, Krzysztof
Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> to: Samin Guo <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org data: 2023/3/16 > On 16/03/2023 05:37, Samin Guo wrote: >> From: Yanhong Wang <yanhong.wang@starfivetech.com> >> >> Add documentation to describe StarFive dwmac driver(GMAC). >> > Thank you for your patch. There is something to discuss/improve. > >> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com> >> Signed-off-by: Samin Guo <samin.guo@starfivetech.com> >> Tested-by: Tommaso Merciai <tomm.merciai@gmail.com> >> --- >> .../devicetree/bindings/net/snps,dwmac.yaml | 1 + >> .../bindings/net/starfive,jh7110-dwmac.yaml | 130 ++++++++++++++++++ >> MAINTAINERS | 6 + >> 3 files changed, 137 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> index e4519cf722ab..245f7d713261 100644 >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> @@ -91,6 +91,7 @@ properties: >> - snps,dwmac-5.20 >> - snps,dwxgmac >> - snps,dwxgmac-2.10 >> + - starfive,jh7110-dwmac >> >> reg: >> minItems: 1 >> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> new file mode 100644 >> index 000000000000..b59e6bd8201f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> @@ -0,0 +1,130 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2022 StarFive Technology Co., Ltd. >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 DWMAC glue layer >> + >> +maintainers: >> + - Emil Renner Berthing <kernel@esmil.dk> >> + - Samin Guo <samin.guo@starfivetech.com> >> + >> +select: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - starfive,jh7110-dwmac >> + required: >> + - compatible >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - starfive,jh7110-dwmac >> + - const: snps,dwmac-5.20 >> + > > reg: > maxItems: 1 Thanks, I will add it in next version. > > >> + clocks: >> + items: >> + - description: GMAC main clock >> + - description: GMAC AHB clock >> + - description: PTP clock >> + - description: TX clock >> + - description: GTX clock >> + >> + clock-names: >> + items: >> + - const: stmmaceth >> + - const: pclk >> + - const: ptp_ref >> + - const: tx >> + - const: gtx >> + > > interrupts: ??? Thanks, I will add it in next version. > >> + resets: >> + items: >> + - description: MAC Reset signal. >> + - description: AHB Reset signal. >> + >> + reset-names: >> + items: >> + - const: stmmaceth >> + - const: ahb >> + >> + starfive,tx-use-rgmii-clk: >> + description: >> + Tx clock is provided by external rgmii clock. >> + type: boolean >> + >> + starfive,syscon: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + items: >> + - items: >> + - description: phandle to syscon that configures phy mode >> + - description: Offset of phy mode selection >> + - description: Shift of phy mode selection >> + description: >> + A phandle to syscon with two arguments that configure phy mode. >> + The argument one is the offset of phy mode selection, the >> + argument two is the shift of phy mode selection. >> + >> +allOf: >> + - $ref: snps,dwmac.yaml# >> + >> +unevaluatedProperties: false >> + > Best regards, > Krzysztof > Best regards, Samin
-------- 原始信息 -------- 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 收件人: Samin Guo <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org 日期: 2023/3/16 > On 16/03/2023 05:37, Samin Guo wrote: >> From: Yanhong Wang <yanhong.wang@starfivetech.com> >> >> Add documentation to describe StarFive dwmac driver(GMAC). >> > Thank you for your patch. There is something to discuss/improve. > >> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com> >> Signed-off-by: Samin Guo <samin.guo@starfivetech.com> >> Tested-by: Tommaso Merciai <tomm.merciai@gmail.com> >> --- >> .../devicetree/bindings/net/snps,dwmac.yaml | 1 + >> .../bindings/net/starfive,jh7110-dwmac.yaml | 130 ++++++++++++++++++ >> MAINTAINERS | 6 + >> 3 files changed, 137 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> index e4519cf722ab..245f7d713261 100644 >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> @@ -91,6 +91,7 @@ properties: >> - snps,dwmac-5.20 >> - snps,dwxgmac >> - snps,dwxgmac-2.10 >> + - starfive,jh7110-dwmac >> >> reg: >> minItems: 1 >> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> new file mode 100644 >> index 000000000000..b59e6bd8201f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >> @@ -0,0 +1,130 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2022 StarFive Technology Co., Ltd. >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 DWMAC glue layer >> + >> +maintainers: >> + - Emil Renner Berthing <kernel@esmil.dk> >> + - Samin Guo <samin.guo@starfivetech.com> >> + >> +select: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - starfive,jh7110-dwmac >> + required: >> + - compatible >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - starfive,jh7110-dwmac >> + - const: snps,dwmac-5.20 >> + > > reg: > maxItems: 1 > >> + clocks: >> + items: >> + - description: GMAC main clock >> + - description: GMAC AHB clock >> + - description: PTP clock >> + - description: TX clock >> + - description: GTX clock >> + >> + clock-names: >> + items: >> + - const: stmmaceth >> + - const: pclk >> + - const: ptp_ref >> + - const: tx >> + - const: gtx >> + > > interrupts: ??? > Hi Krzysztof, snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes, and the JH7110 SoC is also applicable. Maybe just add reg/interrupt/interrupt-names to the required ? required: - compatible + - reg - clocks - clock-names + - interrupts + - interrupt-names - resets - reset-names Best regards, Samin >> + resets: >> + items: >> + - description: MAC Reset signal. >> + - description: AHB Reset signal. >> + >> + reset-names: >> + items: >> + - const: stmmaceth >> + - const: ahb >> + >> + starfive,tx-use-rgmii-clk: >> + description: >> + Tx clock is provided by external rgmii clock. >> + type: boolean >> + >> + starfive,syscon: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + items: >> + - items: >> + - description: phandle to syscon that configures phy mode >> + - description: Offset of phy mode selection >> + - description: Shift of phy mode selection >> + description: >> + A phandle to syscon with two arguments that configure phy mode. >> + The argument one is the offset of phy mode selection, the >> + argument two is the shift of phy mode selection. >> + >> +allOf: >> + - $ref: snps,dwmac.yaml# >> + >> +unevaluatedProperties: false >> + > Best regards, > Krzysztof >
On 16/03/2023 09:02, Guo Samin wrote: > > > -------- 原始信息 -------- > 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > 收件人: Samin Guo <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org > 日期: 2023/3/16 > >> On 16/03/2023 05:37, Samin Guo wrote: >>> From: Yanhong Wang <yanhong.wang@starfivetech.com> >>> >>> Add documentation to describe StarFive dwmac driver(GMAC). >>> >> Thank you for your patch. There is something to discuss/improve. >> >>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com> >>> Signed-off-by: Samin Guo <samin.guo@starfivetech.com> >>> Tested-by: Tommaso Merciai <tomm.merciai@gmail.com> >>> --- >>> .../devicetree/bindings/net/snps,dwmac.yaml | 1 + >>> .../bindings/net/starfive,jh7110-dwmac.yaml | 130 ++++++++++++++++++ >>> MAINTAINERS | 6 + >>> 3 files changed, 137 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> index e4519cf722ab..245f7d713261 100644 >>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> @@ -91,6 +91,7 @@ properties: >>> - snps,dwmac-5.20 >>> - snps,dwxgmac >>> - snps,dwxgmac-2.10 >>> + - starfive,jh7110-dwmac >>> >>> reg: >>> minItems: 1 >>> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>> new file mode 100644 >>> index 000000000000..b59e6bd8201f >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>> @@ -0,0 +1,130 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +# Copyright (C) 2022 StarFive Technology Co., Ltd. >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: StarFive JH7110 DWMAC glue layer >>> + >>> +maintainers: >>> + - Emil Renner Berthing <kernel@esmil.dk> >>> + - Samin Guo <samin.guo@starfivetech.com> >>> + >>> +select: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - starfive,jh7110-dwmac >>> + required: >>> + - compatible >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - starfive,jh7110-dwmac >>> + - const: snps,dwmac-5.20 >>> + >> >> reg: >> maxItems: 1 > >> >>> + clocks: >>> + items: >>> + - description: GMAC main clock >>> + - description: GMAC AHB clock >>> + - description: PTP clock >>> + - description: TX clock >>> + - description: GTX clock >>> + >>> + clock-names: >>> + items: >>> + - const: stmmaceth >>> + - const: pclk >>> + - const: ptp_ref >>> + - const: tx >>> + - const: gtx >>> + >> >> interrupts: ??? >> > > Hi Krzysztof, > > snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes, > and the JH7110 SoC is also applicable. > Maybe just add reg/interrupt/interrupt-names to the required ? You need to constrain them. > > > required: > - compatible > + - reg > - clocks > - clock-names > + - interrupts > + - interrupt-names > - resets > - reset-names Best regards, Krzysztof
Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> to: Guo Samin <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org data: 2023/3/16 > On 16/03/2023 09:02, Guo Samin wrote: >> >> >> -------- 原始信息 -------- >> 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> 收件人: Samin Guo <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org >> 日期: 2023/3/16 >> >>> On 16/03/2023 05:37, Samin Guo wrote: >>>> From: Yanhong Wang <yanhong.wang@starfivetech.com> >>>> >>>> Add documentation to describe StarFive dwmac driver(GMAC). >>>> >>> Thank you for your patch. There is something to discuss/improve. >>> >>>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com> >>>> Signed-off-by: Samin Guo <samin.guo@starfivetech.com> >>>> Tested-by: Tommaso Merciai <tomm.merciai@gmail.com> >>>> --- >>>> .../devicetree/bindings/net/snps,dwmac.yaml | 1 + >>>> .../bindings/net/starfive,jh7110-dwmac.yaml | 130 ++++++++++++++++++ >>>> MAINTAINERS | 6 + >>>> 3 files changed, 137 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> index e4519cf722ab..245f7d713261 100644 >>>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>>> @@ -91,6 +91,7 @@ properties: >>>> - snps,dwmac-5.20 >>>> - snps,dwxgmac >>>> - snps,dwxgmac-2.10 >>>> + - starfive,jh7110-dwmac >>>> >>>> reg: >>>> minItems: 1 >>>> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>>> new file mode 100644 >>>> index 000000000000..b59e6bd8201f >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml >>>> @@ -0,0 +1,130 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +# Copyright (C) 2022 StarFive Technology Co., Ltd. >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: StarFive JH7110 DWMAC glue layer >>>> + >>>> +maintainers: >>>> + - Emil Renner Berthing <kernel@esmil.dk> >>>> + - Samin Guo <samin.guo@starfivetech.com> >>>> + >>>> +select: >>>> + properties: >>>> + compatible: >>>> + contains: >>>> + enum: >>>> + - starfive,jh7110-dwmac >>>> + required: >>>> + - compatible >>>> + >>>> +properties: >>>> + compatible: >>>> + items: >>>> + - enum: >>>> + - starfive,jh7110-dwmac >>>> + - const: snps,dwmac-5.20 >>>> + >>> >>> reg: >>> maxItems: 1 >> >>> >>>> + clocks: >>>> + items: >>>> + - description: GMAC main clock >>>> + - description: GMAC AHB clock >>>> + - description: PTP clock >>>> + - description: TX clock >>>> + - description: GTX clock >>>> + >>>> + clock-names: >>>> + items: >>>> + - const: stmmaceth >>>> + - const: pclk >>>> + - const: ptp_ref >>>> + - const: tx >>>> + - const: gtx >>>> + >>> >>> interrupts: ??? >>> >> >> Hi Krzysztof, >> >> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes, >> and the JH7110 SoC is also applicable. >> Maybe just add reg/interrupt/interrupt-names to the required ? > > You need to constrain them. I see. I will add reg constraints in the next version, thanks. I have one more question, the interrupts/interrup-names of JH7110 SoC's gmac are exactly the same as snps,dwmac.yaml, do these also need to be constrained? Best regards, Samin > >> >> >> required: >> - compatible >> + - reg >> - clocks >> - clock-names >> + - interrupts >> + - interrupt-names >> - resets >> - reset-names > Best regards, > Krzysztof >
On 16/03/2023 09:15, Guo Samin wrote: >>>> interrupts: ??? >>>> >>> >>> Hi Krzysztof, >>> >>> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes, >>> and the JH7110 SoC is also applicable. >>> Maybe just add reg/interrupt/interrupt-names to the required ? >> >> You need to constrain them. > > > I see. I will add reg constraints in the next version, thanks. > > I have one more question, the interrupts/interrup-names of JH7110 SoC's gmac are exactly the same as snps,dwmac.yaml, > do these also need to be constrained? The interrupts on common binding are variable, so you need to constrain them - you have fixed number of them, right? Best regards, Krzysztof
-------- 原始信息 -------- 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 收件人: Guo Samin <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org 日期: 2023/3/16 > On 16/03/2023 09:15, Guo Samin wrote: >>>>> interrupts: ??? >>>>> >>>> >>>> Hi Krzysztof, >>>> >>>> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes, >>>> and the JH7110 SoC is also applicable. >>>> Maybe just add reg/interrupt/interrupt-names to the required ? >>> >>> You need to constrain them. >> >> >> I see. I will add reg constraints in the next version, thanks. >> >> I have one more question, the interrupts/interrup-names of JH7110 SoC's gmac are exactly the same as snps,dwmac.yaml, >> do these also need to be constrained? > > The interrupts on common binding are variable, so you need to constrain > them - you have fixed number of them, right? > > Best regards, > Krzysztof > Yes, JH7110 fixed is 3 pcs. Thanks, I will constrain them. Best regards, Samin
On 16/03/2023 09:28, Guo Samin wrote: > > > -------- 原始信息 -------- > 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > 收件人: Guo Samin <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org > 日期: 2023/3/16 > >> On 16/03/2023 09:15, Guo Samin wrote: >>>>>> interrupts: ??? >>>>>> >>>>> >>>>> Hi Krzysztof, >>>>> >>>>> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes, >>>>> and the JH7110 SoC is also applicable. >>>>> Maybe just add reg/interrupt/interrupt-names to the required ? >>>> >>>> You need to constrain them. >>> >>> >>> I see. I will add reg constraints in the next version, thanks. >>> >>> I have one more question, the interrupts/interrup-names of JH7110 SoC's gmac are exactly the same as snps,dwmac.yaml, >>> do these also need to be constrained? >> >> The interrupts on common binding are variable, so you need to constrain >> them - you have fixed number of them, right? >> >> Best regards, >> Krzysztof >> > > Yes, JH7110 fixed is 3 pcs. Thanks, I will constrain them. Then just minItems: 3, maxItems: 3 here should be enough Best regards, Krzysztof
-------- 原始信息 -------- Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> to : Guo Samin <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org data: 2023/3/16 > On 16/03/2023 09:28, Guo Samin wrote: >> >> >> -------- 原始信息 -------- >> 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> 收件人: Guo Samin <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org >> 日期: 2023/3/16 >> >>> On 16/03/2023 09:15, Guo Samin wrote: >>>>>>> interrupts: ??? >>>>>>> >>>>>> >>>>>> Hi Krzysztof, >>>>>> >>>>>> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes, >>>>>> and the JH7110 SoC is also applicable. >>>>>> Maybe just add reg/interrupt/interrupt-names to the required ? >>>>> >>>>> You need to constrain them. >>>> >>>> >>>> I see. I will add reg constraints in the next version, thanks. >>>> >>>> I have one more question, the interrupts/interrup-names of JH7110 SoC's gmac are exactly the same as snps,dwmac.yaml, >>>> do these also need to be constrained? >>> >>> The interrupts on common binding are variable, so you need to constrain >>> them - you have fixed number of them, right? >>> >>> Best regards, >>> Krzysztof >>> >> >> Yes, JH7110 fixed is 3 pcs. Thanks, I will constrain them. > > Then just minItems: 3, maxItems: 3 here should be enough > > Best regards, > Krzysztof > Hi Krzysztof, Thank you for the suggestion. I'll change it like this in the next version, is right? $ git diff --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml @@ -27,6 +27,9 @@ properties: - starfive,jh7110-dwmac - const: snps,dwmac-5.20 + reg: + maxItems: 1 + clocks: items: - description: GMAC main clock @@ -43,6 +46,14 @@ properties: - const: tx - const: gtx + interrupts: + minItems: 3 + maxItems: 3 + + interrupt-names: + minItems: 3 + maxItems: 3 + resets: items: - description: MAC Reset signal. @@ -77,8 +88,11 @@ unevaluatedProperties: false required: - compatible + - reg - clocks - clock-names + - interrupts + - interrupt-names - resets - reset-names Best regards, Samin
On 16/03/2023 11:18, Guo Samin wrote: > > > -------- 原始信息 -------- > Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > to : Guo Samin <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org > data: 2023/3/16 > >> On 16/03/2023 09:28, Guo Samin wrote: >>> >>> >>> -------- 原始信息 -------- >>> 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac >>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> 收件人: Guo Samin <samin.guo@starfivetech.com>, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org >>> 日期: 2023/3/16 >>> >>>> On 16/03/2023 09:15, Guo Samin wrote: >>>>>>>> interrupts: ??? >>>>>>>> >>>>>>> >>>>>>> Hi Krzysztof, >>>>>>> >>>>>>> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes, >>>>>>> and the JH7110 SoC is also applicable. >>>>>>> Maybe just add reg/interrupt/interrupt-names to the required ? >>>>>> >>>>>> You need to constrain them. >>>>> >>>>> >>>>> I see. I will add reg constraints in the next version, thanks. >>>>> >>>>> I have one more question, the interrupts/interrup-names of JH7110 SoC's gmac are exactly the same as snps,dwmac.yaml, >>>>> do these also need to be constrained? >>>> >>>> The interrupts on common binding are variable, so you need to constrain >>>> them - you have fixed number of them, right? >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> >>> Yes, JH7110 fixed is 3 pcs. Thanks, I will constrain them. >> >> Then just minItems: 3, maxItems: 3 here should be enough >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > > Thank you for the suggestion. > I'll change it like this in the next version, is right? Yes, looks good for me. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index e4519cf722ab..245f7d713261 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -91,6 +91,7 @@ properties: - snps,dwmac-5.20 - snps,dwxgmac - snps,dwxgmac-2.10 + - starfive,jh7110-dwmac reg: minItems: 1 diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml new file mode 100644 index 000000000000..b59e6bd8201f --- /dev/null +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml @@ -0,0 +1,130 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2022 StarFive Technology Co., Ltd. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: StarFive JH7110 DWMAC glue layer + +maintainers: + - Emil Renner Berthing <kernel@esmil.dk> + - Samin Guo <samin.guo@starfivetech.com> + +select: + properties: + compatible: + contains: + enum: + - starfive,jh7110-dwmac + required: + - compatible + +properties: + compatible: + items: + - enum: + - starfive,jh7110-dwmac + - const: snps,dwmac-5.20 + + clocks: + items: + - description: GMAC main clock + - description: GMAC AHB clock + - description: PTP clock + - description: TX clock + - description: GTX clock + + clock-names: + items: + - const: stmmaceth + - const: pclk + - const: ptp_ref + - const: tx + - const: gtx + + resets: + items: + - description: MAC Reset signal. + - description: AHB Reset signal. + + reset-names: + items: + - const: stmmaceth + - const: ahb + + starfive,tx-use-rgmii-clk: + description: + Tx clock is provided by external rgmii clock. + type: boolean + + starfive,syscon: + $ref: /schemas/types.yaml#/definitions/phandle-array + items: + - items: + - description: phandle to syscon that configures phy mode + - description: Offset of phy mode selection + - description: Shift of phy mode selection + description: + A phandle to syscon with two arguments that configure phy mode. + The argument one is the offset of phy mode selection, the + argument two is the shift of phy mode selection. + +allOf: + - $ref: snps,dwmac.yaml# + +unevaluatedProperties: false + +required: + - compatible + - clocks + - clock-names + - resets + - reset-names + +examples: + - | + ethernet@16030000 { + compatible = "starfive,jh7110-dwmac", "snps,dwmac-5.20"; + reg = <0x16030000 0x10000>; + clocks = <&clk 3>, <&clk 2>, <&clk 109>, + <&clk 6>, <&clk 111>; + clock-names = "stmmaceth", "pclk", "ptp_ref", + "tx", "gtx"; + resets = <&rst 1>, <&rst 2>; + reset-names = "stmmaceth", "ahb"; + interrupts = <7>, <6>, <5>; + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; + phy-mode = "rgmii-id"; + snps,multicast-filter-bins = <64>; + snps,perfect-filter-entries = <8>; + rx-fifo-depth = <2048>; + tx-fifo-depth = <2048>; + snps,fixed-burst; + snps,no-pbl-x8; + snps,tso; + snps,force_thresh_dma_mode; + snps,axi-config = <&stmmac_axi_setup>; + snps,en-tx-lpi-clockgating; + snps,txpbl = <16>; + snps,rxpbl = <16>; + starfive,syscon = <&aon_syscon 0xc 0x12>; + phy-handle = <&phy0>; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + compatible = "snps,dwmac-mdio"; + + phy0: ethernet-phy@0 { + reg = <0>; + }; + }; + + stmmac_axi_setup: stmmac-axi-config { + snps,lpi_en; + snps,wr_osr_lmt = <4>; + snps,rd_osr_lmt = <4>; + snps,blen = <256 128 64 32 0 0 0>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index fdad60cc9f2e..f876983130ae 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19913,6 +19913,12 @@ M: Emil Renner Berthing <kernel@esmil.dk> S: Maintained F: arch/riscv/boot/dts/starfive/ +STARFIVE DWMAC GLUE LAYER +M: Emil Renner Berthing <kernel@esmil.dk> +M: Samin Guo <samin.guo@starfivetech.com> +S: Maintained +F: Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml + STARFIVE JH71X0 CLOCK DRIVERS M: Emil Renner Berthing <kernel@esmil.dk> M: Hal Feng <hal.feng@starfivetech.com>