diff mbox series

[v1] Bluetooth: mgmt: Fix MGMT add advmon with RSSI command

Message ID 20230316151018.v1.1.I9113bb4f444afc2c5cb19d1e96569e01ddbd8939@changeid (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series [v1] Bluetooth: mgmt: Fix MGMT add advmon with RSSI command | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 19 this patch: 19
netdev/cc_maintainers success CCed 10 of 10 maintainers
netdev/build_clang success Errors and warnings before: 18 this patch: 18
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 19 this patch: 19
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 9 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Howard Chung March 16, 2023, 7:10 a.m. UTC 
From: howardchung <howardchung@google.com>

The MGMT command: MGMT_OP_ADD_ADV_PATTERNS_MONITOR_RSSI uses variable
length argumenent. This patch adds right the field.

Reviewed-by: Archie Pusaka <apusaka@chromium.org>
Fixes: b338d91703fa ("Bluetooth: Implement support for Mesh")
Signed-off-by: howardchung <howardchung@google.com>
---

 net/bluetooth/mgmt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Paul Menzel March 16, 2023, 9:47 a.m. UTC | #1 
Dear Howard,


Thank you for your patch.

Am 16.03.23 um 08:10 schrieb Howard Chung:
> From: howardchung <howardchung@google.com>

Please configure your full name:

     git config --global user.name "Howard Chung"
     git commit -s --amend --author="Howard Chung <howardchung@google.com>"

> The MGMT command: MGMT_OP_ADD_ADV_PATTERNS_MONITOR_RSSI uses variable
> length argumenent. This patch adds right the field.

argument

Were you seeing actual problems? If so, please describe the test setup.

> Reviewed-by: Archie Pusaka <apusaka@chromium.org>
> Fixes: b338d91703fa ("Bluetooth: Implement support for Mesh")
> Signed-off-by: howardchung <howardchung@google.com>
> ---
> 
>   net/bluetooth/mgmt.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 39589f864ea7..249dc6777fb4 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -9357,7 +9357,8 @@ static const struct hci_mgmt_handler mgmt_handlers[] = {
>   	{ add_ext_adv_data,        MGMT_ADD_EXT_ADV_DATA_SIZE,
>   						HCI_MGMT_VAR_LEN },
>   	{ add_adv_patterns_monitor_rssi,
> -				   MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE },
> +				   MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE,
> +						HCI_MGMT_VAR_LEN },
>   	{ set_mesh,                MGMT_SET_MESH_RECEIVER_SIZE,
>   						HCI_MGMT_VAR_LEN },
>   	{ mesh_features,           MGMT_MESH_READ_FEATURES_SIZE },

Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul
Howard Chung March 16, 2023, 9:54 a.m. UTC | #2 
Thanks for the reply!
A new patch has been sent.
Please take a look when available.

Thanks,
Howard


On Thu, Mar 16, 2023 at 5:47 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Howard,
>
>
> Thank you for your patch.
>
> Am 16.03.23 um 08:10 schrieb Howard Chung:
> > From: howardchung <howardchung@google.com>
>
> Please configure your full name:
>
>      git config --global user.name "Howard Chung"
>      git commit -s --amend --author="Howard Chung <howardchung@google.com>"
>
> > The MGMT command: MGMT_OP_ADD_ADV_PATTERNS_MONITOR_RSSI uses variable
> > length argumenent. This patch adds right the field.
>
> argument
>
> Were you seeing actual problems? If so, please describe the test setup.
>
> > Reviewed-by: Archie Pusaka <apusaka@chromium.org>
> > Fixes: b338d91703fa ("Bluetooth: Implement support for Mesh")
> > Signed-off-by: howardchung <howardchung@google.com>
> > ---
> >
> >   net/bluetooth/mgmt.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> > index 39589f864ea7..249dc6777fb4 100644
> > --- a/net/bluetooth/mgmt.c
> > +++ b/net/bluetooth/mgmt.c
> > @@ -9357,7 +9357,8 @@ static const struct hci_mgmt_handler mgmt_handlers[] = {
> >       { add_ext_adv_data,        MGMT_ADD_EXT_ADV_DATA_SIZE,
> >                                               HCI_MGMT_VAR_LEN },
> >       { add_adv_patterns_monitor_rssi,
> > -                                MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE },
> > +                                MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE,
> > +                                             HCI_MGMT_VAR_LEN },
> >       { set_mesh,                MGMT_SET_MESH_RECEIVER_SIZE,
> >                                               HCI_MGMT_VAR_LEN },
> >       { mesh_features,           MGMT_MESH_READ_FEATURES_SIZE },
>
> Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>
>
>
> Kind regards,
>
> Paul
diff mbox series

Patch

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 39589f864ea7..249dc6777fb4 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -9357,7 +9357,8 @@  static const struct hci_mgmt_handler mgmt_handlers[] = {
 	{ add_ext_adv_data,        MGMT_ADD_EXT_ADV_DATA_SIZE,
 						HCI_MGMT_VAR_LEN },
 	{ add_adv_patterns_monitor_rssi,
-				   MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE },
+				   MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE,
+						HCI_MGMT_VAR_LEN },
 	{ set_mesh,                MGMT_SET_MESH_RECEIVER_SIZE,
 						HCI_MGMT_VAR_LEN },
 	{ mesh_features,           MGMT_MESH_READ_FEATURES_SIZE },