diff mbox series

[v2] net: dsa: b53: mmap: fix device tree support

Message ID 20230316172807.460146-1-noltari@gmail.com (mailing list archive)
State Accepted
Commit 30796d0dcb6e41c6558a07950f2ce60c209da867
Delegated to: Netdev Maintainers
Headers show
Series [v2] net: dsa: b53: mmap: fix device tree support | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 18 this patch: 18
netdev/cc_maintainers success CCed 9 of 9 maintainers
netdev/build_clang success Errors and warnings before: 18 this patch: 18
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 18 this patch: 18
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Álvaro Fernández Rojas March 16, 2023, 5:28 p.m. UTC 
CPU port should also be enabled in order to get a working switch.

Fixes: a5538a777b73 ("net: dsa: b53: mmap: Add device tree support")
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 v2: switch to B53_N_PORTS

 drivers/net/dsa/b53/b53_mmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Fainelli March 16, 2023, 5:30 p.m. UTC | #1 
On 3/16/23 10:28, Álvaro Fernández Rojas wrote:
> CPU port should also be enabled in order to get a working switch.
> 
> Fixes: a5538a777b73 ("net: dsa: b53: mmap: Add device tree support")
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
patchwork-bot+netdevbpf@kernel.org March 18, 2023, 5 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 16 Mar 2023 18:28:07 +0100 you wrote:
> CPU port should also be enabled in order to get a working switch.
> 
> Fixes: a5538a777b73 ("net: dsa: b53: mmap: Add device tree support")
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  v2: switch to B53_N_PORTS
> 
> [...]

Here is the summary with links:
  - [v2] net: dsa: b53: mmap: fix device tree support
    https://git.kernel.org/netdev/net/c/30796d0dcb6e

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c
index e968322dfbf0..70887e0aece3 100644
--- a/drivers/net/dsa/b53/b53_mmap.c
+++ b/drivers/net/dsa/b53/b53_mmap.c
@@ -263,7 +263,7 @@  static int b53_mmap_probe_of(struct platform_device *pdev,
 		if (of_property_read_u32(of_port, "reg", &reg))
 			continue;
 
-		if (reg < B53_CPU_PORT)
+		if (reg < B53_N_PORTS)
 			pdata->enabled_ports |= BIT(reg);
 	}