diff mbox series

usb: plusb: remove unused pl_clear_QuickLink_features function

Message ID 20230318131342.1684103-1-trix@redhat.com (mailing list archive)
State Accepted
Commit 7d722c9802d4bd61a1f1614e07413b6a5fac382d
Delegated to: Netdev Maintainers
Headers show
Series usb: plusb: remove unused pl_clear_QuickLink_features function | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 18 this patch: 18
netdev/cc_maintainers success CCed 13 of 13 maintainers
netdev/build_clang success Errors and warnings before: 20 this patch: 18
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 18 this patch: 18
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 12 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 1 now: 0

Commit Message

Tom Rix March 18, 2023, 1:13 p.m. UTC
clang with W=1 reports
drivers/net/usb/plusb.c:65:1: error:
  unused function 'pl_clear_QuickLink_features' [-Werror,-Wunused-function]
pl_clear_QuickLink_features(struct usbnet *dev, int val)
^
This static function is not used, so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/usb/plusb.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 20, 2023, 10:20 a.m. UTC | #1
Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Sat, 18 Mar 2023 09:13:42 -0400 you wrote:
> clang with W=1 reports
> drivers/net/usb/plusb.c:65:1: error:
>   unused function 'pl_clear_QuickLink_features' [-Werror,-Wunused-function]
> pl_clear_QuickLink_features(struct usbnet *dev, int val)
> ^
> This static function is not used, so remove it.
> 
> [...]

Here is the summary with links:
  - usb: plusb: remove unused pl_clear_QuickLink_features function
    https://git.kernel.org/netdev/net/c/7d722c9802d4

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/usb/plusb.c b/drivers/net/usb/plusb.c
index 7a2b0094de51..2894114858a2 100644
--- a/drivers/net/usb/plusb.c
+++ b/drivers/net/usb/plusb.c
@@ -61,12 +61,6 @@  pl_vendor_req(struct usbnet *dev, u8 req, u8 val, u8 index)
 				val, index, NULL, 0);
 }
 
-static inline int
-pl_clear_QuickLink_features(struct usbnet *dev, int val)
-{
-	return pl_vendor_req(dev, 1, (u8) val, 0);
-}
-
 static inline int
 pl_set_QuickLink_features(struct usbnet *dev, int val)
 {