| Message ID | 20230321150725.127229-2-nnac123@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1cc6571f562774f1d928dc8b3cff50829b86e970 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v2,1/2] net: Catch invalid index in XPS mapping | expand |
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 23b0d7eaaadd..838b7310a80b 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -2482,6 +2482,7 @@ static inline struct netdev_queue *netdev_get_tx_queue(const struct net_device *dev, unsigned int index) { + DEBUG_NET_WARN_ON_ONCE(index >= dev->num_tx_queues); return &dev->_tx[index]; }
When requesting a TX queue at a given index, warn on out-of-bounds referencing if the index is greater than the allocated number of queues. Specifically, since this function is used heavily in the networking stack use DEBUG_NET_WARN_ON_ONCE to avoid executing a new branch on every packet. Signed-off-by: Nick Child <nnac123@linux.ibm.com> --- Changes since v1 (respond to Jakubs review): - send to net-next instead of net - use DEBUG_NET_WARN_ON_ONCE instead of a conditonal returning 1st queue v1 - https://lore.kernel.org/netdev/20230320214942.38395e6e@kicinski-fedora-PC1C0HJN/ include/linux/netdevice.h | 1 + 1 file changed, 1 insertion(+)