Message ID | 20230322143130.1432106-4-o.rempel@pengutronix.de (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | net: dsa: microchip: ksz8: fixes for stable | expand |
Hi Oleksij, On Wed, 2023-03-22 at 15:31 +0100, Oleksij Rempel wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > We are using wrong offset, so we will get not a timestamp. > > Fixes: d23a5e18606c ("net: dsa: microchip: move ksz8->masks to > ksz_common") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > drivers/net/dsa/microchip/ksz_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/microchip/ksz_common.c > b/drivers/net/dsa/microchip/ksz_common.c > index 3a1afc9f4621..c914449645ca 100644 > --- a/drivers/net/dsa/microchip/ksz_common.c > +++ b/drivers/net/dsa/microchip/ksz_common.c > @@ -423,7 +423,7 @@ static u8 ksz8863_shifts[] = { > [DYNAMIC_MAC_ENTRIES_H] = 8, > [DYNAMIC_MAC_ENTRIES] = 24, > [DYNAMIC_MAC_FID] = 16, > - [DYNAMIC_MAC_TIMESTAMP] = 24, > + [DYNAMIC_MAC_TIMESTAMP] = 22, Cross verified the bit mask with datasheet. Patch looks good to me. Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com> > [DYNAMIC_MAC_SRC_PORT] = 20, > }; > > -- > 2.30.2 >
diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 3a1afc9f4621..c914449645ca 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -423,7 +423,7 @@ static u8 ksz8863_shifts[] = { [DYNAMIC_MAC_ENTRIES_H] = 8, [DYNAMIC_MAC_ENTRIES] = 24, [DYNAMIC_MAC_FID] = 16, - [DYNAMIC_MAC_TIMESTAMP] = 24, + [DYNAMIC_MAC_TIMESTAMP] = 22, [DYNAMIC_MAC_SRC_PORT] = 20, };
We are using wrong offset, so we will get not a timestamp. Fixes: d23a5e18606c ("net: dsa: microchip: move ksz8->masks to ksz_common") Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/net/dsa/microchip/ksz_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)