| Message ID | 20230322144742.2203947-1-elder@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0c04328ccf8550f29f1357ae90ce460e9568a5a9 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ipa: add IPA v5.0 to ipa_version_string() | expand |
On Wed, Mar 22, 2023 at 09:47:42AM -0500, Alex Elder wrote: > In the IPA device sysfs directory, the "version" file can be read to > find out what IPA version is implemented. The content of this file > is supplied by ipa_version_string(), which needs to be updated to > properly handle IPA v5.0. > > Signed-off-by: Alex Elder <elder@linaro.org> Hi Alex, this patch looks fine. But I am curious. Should IPA_VERSION_5_1 and IPA_VERSION_5_5 also be added? > --- > This should have been included in the previous series... > > drivers/net/ipa/ipa_sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ipa/ipa_sysfs.c b/drivers/net/ipa/ipa_sysfs.c > index 14bd2f9030453..2ff09ce343b73 100644 > --- a/drivers/net/ipa/ipa_sysfs.c > +++ b/drivers/net/ipa/ipa_sysfs.c > @@ -36,6 +36,8 @@ static const char *ipa_version_string(struct ipa *ipa) > return "4.9"; > case IPA_VERSION_4_11: > return "4.11"; > + case IPA_VERSION_5_0: > + return "5.0"; > default: > return "0.0"; /* Won't happen (checked at probe time) */ > } > -- > 2.34.1 >
On 3/22/23 3:56 PM, Simon Horman wrote:
> Should IPA_VERSION_5_1 and IPA_VERSION_5_5 also be added?
They could, since their symbols are defined.
We expect to support both of those versions pretty
soon, and we'll certainly add them to this function
then. For now, unless someone thinks it's important
to add this now, I'd rather keep it this way.
-Alex
On Wed, Mar 22, 2023 at 04:08:01PM -0500, Alex Elder wrote: > On 3/22/23 3:56 PM, Simon Horman wrote: > > Should IPA_VERSION_5_1 and IPA_VERSION_5_5 also be added? > > They could, since their symbols are defined. > > We expect to support both of those versions pretty > soon, and we'll certainly add them to this function > then. For now, unless someone thinks it's important > to add this now, I'd rather keep it this way. Thanks for the clarification. FWIIW, Reviewed-by: Simon Horman <simon.horman@corigine.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 22 Mar 2023 09:47:42 -0500 you wrote: > In the IPA device sysfs directory, the "version" file can be read to > find out what IPA version is implemented. The content of this file > is supplied by ipa_version_string(), which needs to be updated to > properly handle IPA v5.0. > > Signed-off-by: Alex Elder <elder@linaro.org> > > [...] Here is the summary with links: - [net-next] net: ipa: add IPA v5.0 to ipa_version_string() https://git.kernel.org/netdev/net-next/c/0c04328ccf85 You are awesome, thank you!
diff --git a/drivers/net/ipa/ipa_sysfs.c b/drivers/net/ipa/ipa_sysfs.c index 14bd2f9030453..2ff09ce343b73 100644 --- a/drivers/net/ipa/ipa_sysfs.c +++ b/drivers/net/ipa/ipa_sysfs.c @@ -36,6 +36,8 @@ static const char *ipa_version_string(struct ipa *ipa) return "4.9"; case IPA_VERSION_4_11: return "4.11"; + case IPA_VERSION_5_0: + return "5.0"; default: return "0.0"; /* Won't happen (checked at probe time) */ }
In the IPA device sysfs directory, the "version" file can be read to find out what IPA version is implemented. The content of this file is supplied by ipa_version_string(), which needs to be updated to properly handle IPA v5.0. Signed-off-by: Alex Elder <elder@linaro.org> --- This should have been included in the previous series... drivers/net/ipa/ipa_sysfs.c | 2 ++ 1 file changed, 2 insertions(+)