| Message ID | 20230326001733.1343274-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2bcc74ffd21a748fb310135175a1f6b271397e0f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | qed: remove unused num_ooo_add_to_peninsula variable | expand |
On Sat, Mar 25, 2023 at 08:17:33PM -0400, Tom Rix wrote: > clang with W=1 reports > drivers/net/ethernet/qlogic/qed/qed_ll2.c:649:6: error: variable > 'num_ooo_add_to_peninsula' set but not used [-Werror,-Wunused-but-set-variable] > u32 num_ooo_add_to_peninsula = 0, cid; > ^ > This variable is not used so remove it. > > Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sat, 25 Mar 2023 20:17:33 -0400 you wrote: > clang with W=1 reports > drivers/net/ethernet/qlogic/qed/qed_ll2.c:649:6: error: variable > 'num_ooo_add_to_peninsula' set but not used [-Werror,-Wunused-but-set-variable] > u32 num_ooo_add_to_peninsula = 0, cid; > ^ > This variable is not used so remove it. > > [...] Here is the summary with links: - qed: remove unused num_ooo_add_to_peninsula variable https://git.kernel.org/netdev/net-next/c/2bcc74ffd21a You are awesome, thank you!
diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c index e5116a86cfbc..717a0b3f89bd 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c @@ -646,13 +646,13 @@ static int qed_ll2_lb_rxq_handler(struct qed_hwfn *p_hwfn, struct qed_ll2_rx_queue *p_rx = &p_ll2_conn->rx_queue; u16 packet_length = 0, parse_flags = 0, vlan = 0; struct qed_ll2_rx_packet *p_pkt = NULL; - u32 num_ooo_add_to_peninsula = 0, cid; union core_rx_cqe_union *cqe = NULL; u16 cq_new_idx = 0, cq_old_idx = 0; struct qed_ooo_buffer *p_buffer; struct ooo_opaque *ooo_opq; u8 placement_offset = 0; u8 cqe_type; + u32 cid; cq_new_idx = le16_to_cpu(*p_rx->p_fw_cons); cq_old_idx = qed_chain_get_cons_idx(&p_rx->rcq_chain); @@ -762,7 +762,6 @@ static int qed_ll2_lb_rxq_handler(struct qed_hwfn *p_hwfn, cid, ooo_opq->ooo_isle); break; case TCP_EVENT_ADD_PEN: - num_ooo_add_to_peninsula++; qed_ooo_put_ready_buffer(p_hwfn, p_hwfn->p_ooo_info, p_buffer, true);
clang with W=1 reports drivers/net/ethernet/qlogic/qed/qed_ll2.c:649:6: error: variable 'num_ooo_add_to_peninsula' set but not used [-Werror,-Wunused-but-set-variable] u32 num_ooo_add_to_peninsula = 0, cid; ^ This variable is not used so remove it. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/net/ethernet/qlogic/qed/qed_ll2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)