| Message ID | 20230404044823.3226144-1-yoong.siang.song@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | 24e3fce00c0b557491ff596c0682a29dee6fe848 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,1/1] net: stmmac: Add queue reset into stmmac_xdp_open() function | expand |
On Tue, 2023-04-04 at 12:48 +0800, Song Yoong Siang wrote: > Queue reset was moved out from __init_dma_rx_desc_rings() and > __init_dma_tx_desc_rings() functions. Thus, the driver fails to transmit > and receive packet after XDP prog setup. > > This commit adds the missing queue reset into stmmac_xdp_open() function. > > Fixes: f9ec5723c3db ("net: ethernet: stmicro: stmmac: move queue reset to dedicated functions") > Cc: <stable@vger.kernel.org> # 6.0+ > Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 3e5bbfe3c41b..e4c27eb17bd2 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -6630,6 +6630,8 @@ int stmmac_xdp_open(struct net_device *dev) > goto init_error; > } > > + stmmac_reset_queues_param(priv); > + > /* DMA CSR Channel configuration */ > for (chan = 0; chan < dma_csr_ch; chan++) { > stmmac_init_chan(priv, priv->ioaddr, priv->plat->dma_cfg, chan); Looks good to me. Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 4 Apr 2023 12:48:23 +0800 you wrote: > Queue reset was moved out from __init_dma_rx_desc_rings() and > __init_dma_tx_desc_rings() functions. Thus, the driver fails to transmit > and receive packet after XDP prog setup. > > This commit adds the missing queue reset into stmmac_xdp_open() function. > > Fixes: f9ec5723c3db ("net: ethernet: stmicro: stmmac: move queue reset to dedicated functions") > Cc: <stable@vger.kernel.org> # 6.0+ > Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com> > > [...] Here is the summary with links: - [net,1/1] net: stmmac: Add queue reset into stmmac_xdp_open() function https://git.kernel.org/netdev/net/c/24e3fce00c0b You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 3e5bbfe3c41b..e4c27eb17bd2 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -6630,6 +6630,8 @@ int stmmac_xdp_open(struct net_device *dev) goto init_error; } + stmmac_reset_queues_param(priv); + /* DMA CSR Channel configuration */ for (chan = 0; chan < dma_csr_ch; chan++) { stmmac_init_chan(priv, priv->ioaddr, priv->plat->dma_cfg, chan);
Queue reset was moved out from __init_dma_rx_desc_rings() and __init_dma_tx_desc_rings() functions. Thus, the driver fails to transmit and receive packet after XDP prog setup. This commit adds the missing queue reset into stmmac_xdp_open() function. Fixes: f9ec5723c3db ("net: ethernet: stmicro: stmmac: move queue reset to dedicated functions") Cc: <stable@vger.kernel.org> # 6.0+ Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ 1 file changed, 2 insertions(+)