| Message ID | 20230404101842.1382986-4-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b5751cdd7dbe618a03951bdd4c982a71ba448b1b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: microchip: ksz8: Enhance static MAC table operations and error handling | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Posting correctly formatted |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 18 this patch: 18 |
| netdev/cc_maintainers | success | CCed 10 of 10 maintainers |
| netdev/build_clang | success | Errors and warnings before: 18 this patch: 18 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 18 this patch: 18 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 18 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Tue, Apr 04, 2023 at 12:18:38PM +0200, Oleksij Rempel wrote: > As ksz8_r_sta_mac_table() is only used within ksz8795.c, there is no need > to export it. Make the function static for better encapsulation. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Hi Oleksij, On Tue, 2023-04-04 at 12:18 +0200, Oleksij Rempel wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > As ksz8_r_sta_mac_table() is only used within ksz8795.c, there is no > need > to export it. Make the function static for better encapsulation. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > drivers/net/dsa/microchip/ksz8.h | 2 -- > drivers/net/dsa/microchip/ksz8795.c | 4 ++-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/dsa/microchip/ksz8.h > b/drivers/net/dsa/microchip/ksz8.h > index ad2c3a72a576..d87f8ebc6323 100644 > --- a/drivers/net/dsa/microchip/ksz8.h > +++ b/drivers/net/dsa/microchip/ksz8.h > @@ -21,8 +21,6 @@ int ksz8_r_phy(struct ksz_device *dev, u16 phy, u16 > reg, u16 *val); > int ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val); > int ksz8_r_dyn_mac_table(struct ksz_device *dev, u16 addr, u8 > *mac_addr, > u8 *fid, u8 *src_port, u8 *timestamp, u16 > *entries); > -int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr, > - struct alu_struct *alu); ksz8_r_dyn_mac_table() also not used outside KSZ8795.h. It can also be made static Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
On Tue, Apr 04, 2023 at 03:11:02PM +0000, Arun.Ramadoss@microchip.com wrote: > Hi Oleksij, > On Tue, 2023-04-04 at 12:18 +0200, Oleksij Rempel wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > As ksz8_r_sta_mac_table() is only used within ksz8795.c, there is no > > need > > to export it. Make the function static for better encapsulation. > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > drivers/net/dsa/microchip/ksz8.h | 2 -- > > drivers/net/dsa/microchip/ksz8795.c | 4 ++-- > > 2 files changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/dsa/microchip/ksz8.h > > b/drivers/net/dsa/microchip/ksz8.h > > index ad2c3a72a576..d87f8ebc6323 100644 > > --- a/drivers/net/dsa/microchip/ksz8.h > > +++ b/drivers/net/dsa/microchip/ksz8.h > > @@ -21,8 +21,6 @@ int ksz8_r_phy(struct ksz_device *dev, u16 phy, u16 > > reg, u16 *val); > > int ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val); > > int ksz8_r_dyn_mac_table(struct ksz_device *dev, u16 addr, u8 > > *mac_addr, > > u8 *fid, u8 *src_port, u8 *timestamp, u16 > > *entries); > > -int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr, > > - struct alu_struct *alu); > > > ksz8_r_dyn_mac_table() also not used outside KSZ8795.h. It can > also be made static :) Ack, i have pending series of patch for dyn MAC table. > Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
diff --git a/drivers/net/dsa/microchip/ksz8.h b/drivers/net/dsa/microchip/ksz8.h index ad2c3a72a576..d87f8ebc6323 100644 --- a/drivers/net/dsa/microchip/ksz8.h +++ b/drivers/net/dsa/microchip/ksz8.h @@ -21,8 +21,6 @@ int ksz8_r_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 *val); int ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val); int ksz8_r_dyn_mac_table(struct ksz_device *dev, u16 addr, u8 *mac_addr, u8 *fid, u8 *src_port, u8 *timestamp, u16 *entries); -int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr, - struct alu_struct *alu); void ksz8_w_sta_mac_table(struct ksz_device *dev, u16 addr, struct alu_struct *alu); void ksz8_r_mib_cnt(struct ksz_device *dev, int port, u16 addr, u64 *cnt); diff --git a/drivers/net/dsa/microchip/ksz8795.c b/drivers/net/dsa/microchip/ksz8795.c index ee68e166fc44..fc079d6eee80 100644 --- a/drivers/net/dsa/microchip/ksz8795.c +++ b/drivers/net/dsa/microchip/ksz8795.c @@ -457,8 +457,8 @@ int ksz8_r_dyn_mac_table(struct ksz_device *dev, u16 addr, u8 *mac_addr, return rc; } -int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr, - struct alu_struct *alu) +static int ksz8_r_sta_mac_table(struct ksz_device *dev, u16 addr, + struct alu_struct *alu) { u32 data_hi, data_lo; const u8 *shifts;
As ksz8_r_sta_mac_table() is only used within ksz8795.c, there is no need to export it. Make the function static for better encapsulation. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/net/dsa/microchip/ksz8.h | 2 -- drivers/net/dsa/microchip/ksz8795.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-)