From patchwork Fri Apr 7 02:36:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zhongjun@uniontech.com X-Patchwork-Id: 13204424 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A8B6C76196 for ; Fri, 7 Apr 2023 02:38:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232925AbjDGCia (ORCPT ); Thu, 6 Apr 2023 22:38:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230250AbjDGCia (ORCPT ); Thu, 6 Apr 2023 22:38:30 -0400 Received: from smtpbg156.qq.com (smtpbg156.qq.com [15.184.82.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40C571FEC for ; Thu, 6 Apr 2023 19:38:23 -0700 (PDT) X-QQ-mid: bizesmtp73t1680835028tru79yj9 Received: from localhost.localdomain ( [110.191.179.216]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 07 Apr 2023 10:37:06 +0800 (CST) X-QQ-SSF: 01400000000000H0X000000A0000000 X-QQ-FEAT: i75H2eCteEh7nZH4hSJ8T5c20B5ypGt08koS1WWWUShfUrYWvATI5yteFoT31 h81rBu32AYjnwmFvnC+X3TwPKjKHyk9JRphN/TKO0H1NRf9UTyy9w+F3MQOCPymFkl/R95I D0MTshDinjqt4N6+0hSvISCnct7//sqG3SOHHkO6O9JGqC9/ZtQLqHXAh1orHuJXNTFNKjX ZAQqRysph3fmgywtASGMU3HAmEA8XivPD+IGpZY9axGU90iOp6r5ol1JbXOJtNaBfz+ql68 viiFwRhI4SSbKxUUwmIl8BcRLk3kOL85D0hN42JECLc1SzzcgHVu4Ap3yVB8Uf3EK+7KriC bA7ApagD0ypdlnZ0ibsq6RSc3K0/7ErLPM+vUq9RjQuorlN4QSAKOTfA3aC6g== X-QQ-GoodBg: 1 X-BIZMAIL-ID: 14019627429615166144 From: zhongjun@uniontech.com To: bpf@vger.kernel.org Cc: zhongjun Subject: [PATCH] BPF: remove useless condition check Date: Fri, 7 Apr 2023 10:36:50 +0800 Message-Id: <20230407023650.10145-1-zhongjun@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybglogicsvr:qybglogicsvr2 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org X-Patchwork-Delegate: bpf@iogearbox.net From: zhongjun According to contents of 'linux/bpf_types.h', array size of bpf_verifier_ops will never be ZERO. Removing useless check to make code more straight and optimal. Signed-off-by: Jun Zhong base-commit: 738a96c4a8c36950803fdd27e7c30aca92dccefd --- kernel/bpf/verifier.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index d517d13878cf..21047b26dae7 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -17655,10 +17655,6 @@ int bpf_check(struct bpf_prog **prog, union bpf_attr *attr, bpfptr_t uattr) int i, len, ret = -EINVAL; bool is_priv; - /* no program is valid */ - if (ARRAY_SIZE(bpf_verifier_ops) == 0) - return -EINVAL; - /* 'struct bpf_verifier_env' can be global, but since it's not small, * allocate/free it every time bpf_check() is called */