| Message ID | 20230410232719.1561950-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 136f36c74b0345d5d0087d4094894a006470bbd5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: ti/cpsw: Add explicit platform_device.h and of_platform.h includes | expand |
On 4/10/2023 4:27 PM, Rob Herring wrote: > TI CPSW uses of_platform_* functions which are declared in of_platform.h. > of_platform.h gets implicitly included by of_device.h, but that is going > to be removed soon. Nothing else depends on of_device.h so it can be > dropped. of_platform.h also implicitly includes platform_device.h, so > add an explicit include for it, too. > > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Mon, 10 Apr 2023 18:27:19 -0500 you wrote: > TI CPSW uses of_platform_* functions which are declared in of_platform.h. > of_platform.h gets implicitly included by of_device.h, but that is going > to be removed soon. Nothing else depends on of_device.h so it can be > dropped. of_platform.h also implicitly includes platform_device.h, so > add an explicit include for it, too. > > Signed-off-by: Rob Herring <robh@kernel.org> > > [...] Here is the summary with links: - net: ti/cpsw: Add explicit platform_device.h and of_platform.h includes https://git.kernel.org/netdev/net/c/136f36c74b03 You are awesome, thank you!
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 37f0b62ec5d6..f9cd566d1c9b 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -27,7 +27,7 @@ #include <linux/of.h> #include <linux/of_mdio.h> #include <linux/of_net.h> -#include <linux/of_device.h> +#include <linux/of_platform.h> #include <linux/if_vlan.h> #include <linux/kmemleak.h> #include <linux/sys_soc.h> diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c index 35128dd45ffc..c61e4e44a78f 100644 --- a/drivers/net/ethernet/ti/cpsw_new.c +++ b/drivers/net/ethernet/ti/cpsw_new.c @@ -7,6 +7,7 @@ #include <linux/io.h> #include <linux/clk.h> +#include <linux/platform_device.h> #include <linux/timer.h> #include <linux/module.h> #include <linux/irqreturn.h> @@ -23,7 +24,7 @@ #include <linux/of.h> #include <linux/of_mdio.h> #include <linux/of_net.h> -#include <linux/of_device.h> +#include <linux/of_platform.h> #include <linux/if_vlan.h> #include <linux/kmemleak.h> #include <linux/sys_soc.h>
TI CPSW uses of_platform_* functions which are declared in of_platform.h. of_platform.h gets implicitly included by of_device.h, but that is going to be removed soon. Nothing else depends on of_device.h so it can be dropped. of_platform.h also implicitly includes platform_device.h, so add an explicit include for it, too. Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/net/ethernet/ti/cpsw.c | 2 +- drivers/net/ethernet/ti/cpsw_new.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)