| Message ID | 20230413012252.184434-1-rrameshbabu@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3ea31e66644b263f43850174847956fbbe2c28cf |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] tools: ynl: Remove absolute paths to yaml files from ethtool testing tool | expand |
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 12 Apr 2023 18:22:51 -0700 you wrote: > Absolute paths for the spec and schema files make the ethtool testing tool > unusable with freshly checked-out source trees. Replace absolute paths with > relative paths for both files in the Documentation/ directory. > > Issue seen before the change > > Traceback (most recent call last): > File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/./ethtool", line 424, in <module> > main() > File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/./ethtool", line 158, in main > ynl = YnlFamily(spec, schema) > File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/lib/ynl.py", line 342, in __init__ > super().__init__(def_path, schema) > File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/lib/nlspec.py", line 333, in __init__ > with open(spec_path, "r") as stream: > FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/google/home/sdf/src/linux/Documentation/netlink/specs/ethtool.yaml' > > [...] Here is the summary with links: - [net-next,1/2] tools: ynl: Remove absolute paths to yaml files from ethtool testing tool (no matching commit) - [net-next,2/2] tools: ynl: Rename ethtool to ethtool.py https://git.kernel.org/netdev/net-next/c/f2b3b6a22df7 You are awesome, thank you!
On Thu, 13 Apr 2023 04:20:18 +0000 patchwork-bot+netdevbpf@kernel.org wrote: > Here is the summary with links: > - [net-next,1/2] tools: ynl: Remove absolute paths to yaml files from ethtool testing tool > (no matching commit) > - [net-next,2/2] tools: ynl: Rename ethtool to ethtool.py > https://git.kernel.org/netdev/net-next/c/f2b3b6a22df7 > > You are awesome, thank you! Hi Konstantin, this may be worth investigating, looks like a generic bug. The patch: https://lore.kernel.org/all/20230413012252.184434-2-rrameshbabu@nvidia.com/ has no diff, so I'm guessing it confused the bot and the bot matched on whatever got pushed into the tree next.
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 12 Apr 2023 18:22:51 -0700 you wrote: > Absolute paths for the spec and schema files make the ethtool testing tool > unusable with freshly checked-out source trees. Replace absolute paths with > relative paths for both files in the Documentation/ directory. > > Issue seen before the change > > Traceback (most recent call last): > File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/./ethtool", line 424, in <module> > main() > File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/./ethtool", line 158, in main > ynl = YnlFamily(spec, schema) > File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/lib/ynl.py", line 342, in __init__ > super().__init__(def_path, schema) > File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/lib/nlspec.py", line 333, in __init__ > with open(spec_path, "r") as stream: > FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/google/home/sdf/src/linux/Documentation/netlink/specs/ethtool.yaml' > > [...] Here is the summary with links: - [net-next,1/2] tools: ynl: Remove absolute paths to yaml files from ethtool testing tool https://git.kernel.org/netdev/net-next/c/3ea31e66644b - [net-next,2/2] tools: ynl: Rename ethtool to ethtool.py (no matching commit) You are awesome, thank you!
diff --git a/tools/net/ynl/ethtool b/tools/net/ynl/ethtool index 5fb1d670693a..6c9f7e31250c 100755 --- a/tools/net/ynl/ethtool +++ b/tools/net/ynl/ethtool @@ -152,8 +152,8 @@ def main(): global args args = parser.parse_args() - spec = '/usr/local/google/home/sdf/src/linux/Documentation/netlink/specs/ethtool.yaml' - schema = '/usr/local/google/home/sdf/src/linux/Documentation/netlink/genetlink-legacy.yaml' + spec = '../../../Documentation/netlink/specs/ethtool.yaml' + schema = '../../../Documentation/netlink/genetlink-legacy.yaml' ynl = YnlFamily(spec, schema)
Absolute paths for the spec and schema files make the ethtool testing tool unusable with freshly checked-out source trees. Replace absolute paths with relative paths for both files in the Documentation/ directory. Issue seen before the change Traceback (most recent call last): File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/./ethtool", line 424, in <module> main() File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/./ethtool", line 158, in main ynl = YnlFamily(spec, schema) File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/lib/ynl.py", line 342, in __init__ super().__init__(def_path, schema) File "/home/binary-eater/Documents/mlx/linux/tools/net/ynl/lib/nlspec.py", line 333, in __init__ with open(spec_path, "r") as stream: FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/google/home/sdf/src/linux/Documentation/netlink/specs/ethtool.yaml' Fixes: f3d07b02b2b8 ("tools: ynl: ethtool testing tool") Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com> --- tools/net/ynl/ethtool | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)