From patchwork Wed Apr 26 21:50:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeremy Sowden X-Patchwork-Id: 13224961 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECCE8C77B60 for ; Wed, 26 Apr 2023 22:17:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229889AbjDZWR6 (ORCPT ); Wed, 26 Apr 2023 18:17:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239925AbjDZWR5 (ORCPT ); Wed, 26 Apr 2023 18:17:57 -0400 X-Greylist: delayed 1567 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 26 Apr 2023 15:17:56 PDT Received: from ulthar.dreamlands (wan.azazel.net [81.187.77.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DF1C30EF; Wed, 26 Apr 2023 15:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=azazel.net; s=20220717; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9RDxIrsFE6CSMgp+t6u2SnqF6rodTkxLpdhyr3Uhl4E=; b=pSS8nNo5cmCtAEiOHq8OdGbsJv nAlWRdHYhxe9YupDYm4M8qbwFr9cbIHx2/YmGIWEMqkZ+egNKDn6ODk9j1RlwnjaocnifIQPKOTTR twDTBT/PGX2af2/SoaC61pBPcTpDFjEZ58YqSKtNcYKud/lnVrJrVdjQu28xgTnKsVM8VTo9ViB/5 uzfmoNKnCs013LPas7Uuj3bSC5hdVDu4lrf5akkmy2nNuSl3dx143jjS7D0GFyac3AfySHMJAzR8t yNOBI+YS5GDxU4nvwTnw314l1kQmpWu/+MaHg44XHxooCfwGdc0fV7OIGNzaPYZZ9pTGqCeiGMHq7 Z5Y54haA==; Received: from localhost ([::1] helo=ulthar.dreamlands) by ulthar.dreamlands.azazel.net with esmtp (Exim 4.96) (envelope-from ) id 1prn23-001kAV-0r; Wed, 26 Apr 2023 22:50:35 +0100 From: Jeremy Sowden To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , Roberto Sassu Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH bpf] selftests/bpf: fix pkg-config call building sign-file Date: Wed, 26 Apr 2023 22:50:32 +0100 Message-Id: <20230426215032.415792-1-jeremy@azazel.net> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: ::1 X-SA-Exim-Mail-From: jeremy@azazel.net X-SA-Exim-Scanned: No (on ulthar.dreamlands.azazel.net); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org X-Patchwork-Delegate: bpf@iogearbox.net When building sign-file, the call to get the CFLAGS for libcrypto is missing white-space between `pkg-config` and `--cflags`: $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null) Removing the redirection of stderr, we see: $ make -C tools/testing/selftests/bpf sign-file make: Entering directory '[...]/tools/testing/selftests/bpf' make: pkg-config--cflags: No such file or directory SIGN-FILE sign-file make: Leaving directory '[...]/tools/testing/selftests/bpf' Add the missing space. Fixes: fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc") Signed-off-by: Jeremy Sowden Reviewed-by: Roberto Sassu --- tools/testing/selftests/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index b677dcd0b77a..ad01c9e1ff12 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -197,7 +197,7 @@ $(OUTPUT)/urandom_read: urandom_read.c urandom_read_aux.c $(OUTPUT)/liburandom_r $(OUTPUT)/sign-file: ../../../../scripts/sign-file.c $(call msg,SIGN-FILE,,$@) - $(Q)$(CC) $(shell $(HOSTPKG_CONFIG)--cflags libcrypto 2> /dev/null) \ + $(Q)$(CC) $(shell $(HOSTPKG_CONFIG) --cflags libcrypto 2> /dev/null) \ $< -o $@ \ $(shell $(HOSTPKG_CONFIG) --libs libcrypto 2> /dev/null || echo -lcrypto)