| Message ID | 20230502184740.22722-1-shannon.nelson@amd.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3711d44fac1f80ea69ecb7315fed05b3812a7401 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] ionic: remove noise from ethtool rxnfc error msg | expand |
On Tue, May 02, 2023 at 11:47:40AM -0700, Shannon Nelson wrote: > It seems that ethtool is calling into .get_rxnfc more often with > ETHTOOL_GRXCLSRLCNT which ionic doesn't know about. We don't > need to log a message about it, just return not supported. > > Fixes: aa3198819bea6 ("ionic: Add RSS support") > Signed-off-by: Shannon Nelson <shannon.nelson@amd.com> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 2 May 2023 11:47:40 -0700 you wrote: > It seems that ethtool is calling into .get_rxnfc more often with > ETHTOOL_GRXCLSRLCNT which ionic doesn't know about. We don't > need to log a message about it, just return not supported. > > Fixes: aa3198819bea6 ("ionic: Add RSS support") > Signed-off-by: Shannon Nelson <shannon.nelson@amd.com> > > [...] Here is the summary with links: - [net] ionic: remove noise from ethtool rxnfc error msg https://git.kernel.org/netdev/net/c/3711d44fac1f You are awesome, thank you!
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c index cf33503468a3..9b2b96fa36af 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c @@ -794,7 +794,7 @@ static int ionic_get_rxnfc(struct net_device *netdev, info->data = lif->nxqs; break; default: - netdev_err(netdev, "Command parameter %d is not supported\n", + netdev_dbg(netdev, "Command parameter %d is not supported\n", info->cmd); err = -EOPNOTSUPP; }
It seems that ethtool is calling into .get_rxnfc more often with ETHTOOL_GRXCLSRLCNT which ionic doesn't know about. We don't need to log a message about it, just return not supported. Fixes: aa3198819bea6 ("ionic: Add RSS support") Signed-off-by: Shannon Nelson <shannon.nelson@amd.com> --- drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)