From patchwork Tue May 9 07:50:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liang Li X-Patchwork-Id: 13235432 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEEBF28F6 for ; Tue, 9 May 2023 07:49:32 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6950630D0 for ; Tue, 9 May 2023 00:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683618570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CqHSyvWTGvUCU7F6/o4dGaudW495LmCKIe2eYlUXjHc=; b=IPDVtpyhdb8hqlqzpJv5c5YBJKcWNdsVOuuxwfzvNSmdanLpSTpfAFlTD4l/1/IBhLTER6 u1CqAOy7K/UmcvlAOgXWkmfpMfqpF8z5cZxf7iWd/sYYcjv35NFenWppqgtI+Wy+v5FsSd eZTqAgwdDOBMZqYONZ+xFdP24YI7kM0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-600-qFHaa8odOAC1e2r0b5loMQ-1; Tue, 09 May 2023 03:49:29 -0400 X-MC-Unique: qFHaa8odOAC1e2r0b5loMQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B06152932488; Tue, 9 May 2023 07:49:28 +0000 (UTC) Received: from localhost.localdomain (vm-10-0-76-221.hosted.upshift.rdu2.redhat.com [10.0.76.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id A40A4492C13; Tue, 9 May 2023 07:49:28 +0000 (UTC) From: Liang Li To: netdev@vger.kernel.org Cc: liali@redhat.com, j.vosburgh@gmail.com, razor@blackwall.org, Hangbin Liu Subject: [PATCHv2 net] selftests: bonding: delete unnecessary line. Date: Tue, 9 May 2023 07:50:25 +0000 Message-Id: <20230509075025.952650-1-liali@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-Delegate: kuba@kernel.org "ip link set dev "$devbond1" nomaster" This line code in bond-eth-type-change.sh is unnecessary. Because $devbond1 was not added to any master device. Fixes: 222c94ec0ad4("selftests: bonding: add tests for ether type changes") Signed-off-by: Liang Li Acked-by: Hangbin Liu --- .../selftests/drivers/net/bonding/bond-eth-type-change.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh index 5cdd22048ba7..862e947e17c7 100755 --- a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh +++ b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh @@ -53,7 +53,6 @@ bond_test_enslave_type_change() # restore ARPHRD_ETHER type by enslaving such device ip link set dev "$devbond2" master "$devbond0" check_err $? "could not enslave $devbond2 to $devbond0" - ip link set dev "$devbond1" nomaster bond_check_flags "$devbond0"