diff mbox series

[net-next] selftests: bonding: delete unnecessary line

Message ID 20230509090919.1100329-1-liali@redhat.com (mailing list archive)
State Accepted
Commit 2f0f556713f08515f3017fd35309b1f00fbc8932
Delegated to: Netdev Maintainers
Headers show
Series [net-next] selftests: bonding: delete unnecessary line | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/cc_maintainers warning 3 maintainers not CCed: andy@greyhouse.net shuah@kernel.org linux-kselftest@vger.kernel.org
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success net selftest script(s) already in Makefile
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Liang Li May 9, 2023, 9:09 a.m. UTC 
"ip link set dev "$devbond1" nomaster"
This line code in bond-eth-type-change.sh is unnecessary.
Because $devbond1 was not added to any master device.

Signed-off-by: Liang Li <liali@redhat.com>
Acked-by: Hangbin Liu <liuhangbin@gmail.com>
---
 .../selftests/drivers/net/bonding/bond-eth-type-change.sh        | 1 -
 1 file changed, 1 deletion(-)

Comments

Nikolay Aleksandrov May 9, 2023, 9:10 a.m. UTC | #1 
On 09/05/2023 12:09, Liang Li wrote:
> "ip link set dev "$devbond1" nomaster"
> This line code in bond-eth-type-change.sh is unnecessary.
> Because $devbond1 was not added to any master device.
> 
> Signed-off-by: Liang Li <liali@redhat.com>
> Acked-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
>  .../selftests/drivers/net/bonding/bond-eth-type-change.sh        | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
> index 5cdd22048ba7..862e947e17c7 100755
> --- a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
> +++ b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
> @@ -53,7 +53,6 @@ bond_test_enslave_type_change()
>  	# restore ARPHRD_ETHER type by enslaving such device
>  	ip link set dev "$devbond2" master "$devbond0"
>  	check_err $? "could not enslave $devbond2 to $devbond0"
> -	ip link set dev "$devbond1" nomaster
>  
>  	bond_check_flags "$devbond0"
>  


Thanks,
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
patchwork-bot+netdevbpf@kernel.org May 10, 2023, 9:10 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Tue,  9 May 2023 09:09:19 +0000 you wrote:
> "ip link set dev "$devbond1" nomaster"
> This line code in bond-eth-type-change.sh is unnecessary.
> Because $devbond1 was not added to any master device.
> 
> Signed-off-by: Liang Li <liali@redhat.com>
> Acked-by: Hangbin Liu <liuhangbin@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: bonding: delete unnecessary line
    https://git.kernel.org/netdev/net-next/c/2f0f556713f0

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
index 5cdd22048ba7..862e947e17c7 100755
--- a/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
+++ b/tools/testing/selftests/drivers/net/bonding/bond-eth-type-change.sh
@@ -53,7 +53,6 @@  bond_test_enslave_type_change()
 	# restore ARPHRD_ETHER type by enslaving such device
 	ip link set dev "$devbond2" master "$devbond0"
 	check_err $? "could not enslave $devbond2 to $devbond0"
-	ip link set dev "$devbond1" nomaster
 
 	bond_check_flags "$devbond0"