| Message ID | 20230515084906.61491-1-yunchuan@nfschina.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: liquidio: lio_core: Remove unnecessary (void*) conversions | expand |
On Mon, May 15, 2023 at 04:49:06PM +0800, wuych wrote: > Pointer variables of void * type do not require type cast. > > Signed-off-by: wuych <yunchuan@nfschina.com> > --- > drivers/net/ethernet/cavium/liquidio/lio_core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c > index 882b2be06ea0..10d9dab26c92 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c > @@ -904,8 +904,7 @@ static > int liquidio_schedule_msix_droq_pkt_handler(struct octeon_droq *droq, u64 ret) > { > struct octeon_device *oct = droq->oct_dev; > - struct octeon_device_priv *oct_priv = > - (struct octeon_device_priv *)oct->priv; > + struct octeon_device_priv *oct_priv = oct->priv; > Networking code needs to be in Reverse Christmas Tree order. Longest lines first. This code wasn't really in Reverse Christmas Tree order to begine with but now it's more obvious. regards, dan carpenter
On Mon, May 15, 2023 at 12:28:19PM +0300, Dan Carpenter wrote: > On Mon, May 15, 2023 at 04:49:06PM +0800, wuych wrote: > > Pointer variables of void * type do not require type cast. > > > > Signed-off-by: wuych <yunchuan@nfschina.com> > > --- > > drivers/net/ethernet/cavium/liquidio/lio_core.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c > > index 882b2be06ea0..10d9dab26c92 100644 > > --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c > > +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c > > @@ -904,8 +904,7 @@ static > > int liquidio_schedule_msix_droq_pkt_handler(struct octeon_droq *droq, u64 ret) > > { > > struct octeon_device *oct = droq->oct_dev; > > - struct octeon_device_priv *oct_priv = > > - (struct octeon_device_priv *)oct->priv; > > + struct octeon_device_priv *oct_priv = oct->priv; > > > > Networking code needs to be in Reverse Christmas Tree order. Longest > lines first. This code wasn't really in Reverse Christmas Tree order > to begine with but now it's more obvious. Oh, duh. This obviously can't be reversed because it depends on the first declaration. Sorry for the noise. regards, dan carpenter
On Mon, May 15, 2023 at 05:56:21PM +0300, Dan Carpenter wrote: > On Mon, May 15, 2023 at 12:28:19PM +0300, Dan Carpenter wrote: > > On Mon, May 15, 2023 at 04:49:06PM +0800, wuych wrote: > > > Pointer variables of void * type do not require type cast. > > > > > > Signed-off-by: wuych <yunchuan@nfschina.com> > > > --- > > > drivers/net/ethernet/cavium/liquidio/lio_core.c | 6 ++---- > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c > > > index 882b2be06ea0..10d9dab26c92 100644 > > > --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c > > > +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c > > > @@ -904,8 +904,7 @@ static > > > int liquidio_schedule_msix_droq_pkt_handler(struct octeon_droq *droq, u64 ret) > > > { > > > struct octeon_device *oct = droq->oct_dev; > > > - struct octeon_device_priv *oct_priv = > > > - (struct octeon_device_priv *)oct->priv; > > > + struct octeon_device_priv *oct_priv = oct->priv; > > > > > > > Networking code needs to be in Reverse Christmas Tree order. Longest > > lines first. This code wasn't really in Reverse Christmas Tree order > > to begine with but now it's more obvious. > > Oh, duh. This obviously can't be reversed because it depends on the > first declaration. Sorry for the noise. FWIIW, I think the preferred approach for such cases is to separate the declaration and initialisation. Something like: struct octeon_device *oct = droq->oct_dev; struct octeon_device_priv *oct_priv; oct_priv = oct->priv;
On Mon, 15 May 2023 22:19:31 +0200 Simon Horman wrote: > On Mon, May 15, 2023 at 05:56:21PM +0300, Dan Carpenter wrote: > > On Mon, May 15, 2023 at 12:28:19PM +0300, Dan Carpenter wrote: > > > Networking code needs to be in Reverse Christmas Tree order. Longest > > > lines first. This code wasn't really in Reverse Christmas Tree order > > > to begine with but now it's more obvious. > > > > Oh, duh. This obviously can't be reversed because it depends on the > > first declaration. Sorry for the noise. > > FWIIW, I think the preferred approach for such cases is to > separate the declaration and initialisation. Something like: > > struct octeon_device *oct = droq->oct_dev; > struct octeon_device_priv *oct_priv; > > oct_priv = oct->priv; I don't think these changes are worth bothering with at all, TBH.
On Tue, May 16, 2023 at 08:20:59PM -0700, Jakub Kicinski wrote: > On Mon, 15 May 2023 22:19:31 +0200 Simon Horman wrote: > > On Mon, May 15, 2023 at 05:56:21PM +0300, Dan Carpenter wrote: > > > On Mon, May 15, 2023 at 12:28:19PM +0300, Dan Carpenter wrote: > > > > Networking code needs to be in Reverse Christmas Tree order. Longest > > > > lines first. This code wasn't really in Reverse Christmas Tree order > > > > to begine with but now it's more obvious. > > > > > > Oh, duh. This obviously can't be reversed because it depends on the > > > first declaration. Sorry for the noise. > > > > FWIIW, I think the preferred approach for such cases is to > > separate the declaration and initialisation. Something like: > > > > struct octeon_device *oct = droq->oct_dev; > > struct octeon_device_priv *oct_priv; > > > > oct_priv = oct->priv; > > I don't think these changes are worth bothering with at all, TBH. Understood.
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c index 882b2be06ea0..10d9dab26c92 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c @@ -904,8 +904,7 @@ static int liquidio_schedule_msix_droq_pkt_handler(struct octeon_droq *droq, u64 ret) { struct octeon_device *oct = droq->oct_dev; - struct octeon_device_priv *oct_priv = - (struct octeon_device_priv *)oct->priv; + struct octeon_device_priv *oct_priv = oct->priv; if (droq->ops.poll_mode) { droq->ops.napi_fn(droq); @@ -947,8 +946,7 @@ liquidio_msix_intr_handler(int __maybe_unused irq, void *dev) */ static void liquidio_schedule_droq_pkt_handlers(struct octeon_device *oct) { - struct octeon_device_priv *oct_priv = - (struct octeon_device_priv *)oct->priv; + struct octeon_device_priv *oct_priv = oct->priv; struct octeon_droq *droq; u64 oq_no;
Pointer variables of void * type do not require type cast. Signed-off-by: wuych <yunchuan@nfschina.com> --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)