| Message ID | 20230515204833.2832000-1-andrii@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 387912285917ab51882a513c2f260c8d1a7cab70 |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] selftests/bpf: improve netcnt test robustness | expand |
On Mon, May 15, 2023 at 1:48 PM Andrii Nakryiko <andrii@kernel.org> wrote: > > Change netcnt to demand at least 10K packets, as we frequently see some > stray packet arriving during the test in BPF CI. It seems more important > to make sure we haven't lost any packet than enforcing exact number of > packets. > > Cc: Stanislav Fomichev <sdf@google.com> > Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Acked-by: Stanislav Fomichev <sdf@google.com> I was gonna try to count only icmp packets in the bpf program, but _GE works as well :-) > --- > tools/testing/selftests/bpf/prog_tests/netcnt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/bpf/prog_tests/netcnt.c b/tools/testing/selftests/bpf/prog_tests/netcnt.c > index d3915c58d0e1..c3333edd029f 100644 > --- a/tools/testing/selftests/bpf/prog_tests/netcnt.c > +++ b/tools/testing/selftests/bpf/prog_tests/netcnt.c > @@ -67,12 +67,12 @@ void serial_test_netcnt(void) > } > > /* No packets should be lost */ > - ASSERT_EQ(packets, 10000, "packets"); > + ASSERT_GE(packets, 10000, "packets"); > > /* Let's check that bytes counter matches the number of packets > * multiplied by the size of ipv6 ICMP packet. > */ > - ASSERT_EQ(bytes, packets * 104, "bytes"); > + ASSERT_GE(bytes, packets * 104, "bytes"); > > err: > if (cg_fd != -1) > -- > 2.34.1 >
Hello: This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <martin.lau@kernel.org>: On Mon, 15 May 2023 13:48:33 -0700 you wrote: > Change netcnt to demand at least 10K packets, as we frequently see some > stray packet arriving during the test in BPF CI. It seems more important > to make sure we haven't lost any packet than enforcing exact number of > packets. > > Cc: Stanislav Fomichev <sdf@google.com> > Signed-off-by: Andrii Nakryiko <andrii@kernel.org> > > [...] Here is the summary with links: - [bpf-next] selftests/bpf: improve netcnt test robustness https://git.kernel.org/bpf/bpf-next/c/fdb16e48e1c8 You are awesome, thank you!
Hello: This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <ast@kernel.org>: On Mon, 15 May 2023 13:48:33 -0700 you wrote: > Change netcnt to demand at least 10K packets, as we frequently see some > stray packet arriving during the test in BPF CI. It seems more important > to make sure we haven't lost any packet than enforcing exact number of > packets. > > Cc: Stanislav Fomichev <sdf@google.com> > Signed-off-by: Andrii Nakryiko <andrii@kernel.org> > > [...] Here is the summary with links: - [bpf-next] selftests/bpf: improve netcnt test robustness https://git.kernel.org/bpf/bpf-next/c/387912285917 You are awesome, thank you!
diff --git a/tools/testing/selftests/bpf/prog_tests/netcnt.c b/tools/testing/selftests/bpf/prog_tests/netcnt.c index d3915c58d0e1..c3333edd029f 100644 --- a/tools/testing/selftests/bpf/prog_tests/netcnt.c +++ b/tools/testing/selftests/bpf/prog_tests/netcnt.c @@ -67,12 +67,12 @@ void serial_test_netcnt(void) } /* No packets should be lost */ - ASSERT_EQ(packets, 10000, "packets"); + ASSERT_GE(packets, 10000, "packets"); /* Let's check that bytes counter matches the number of packets * multiplied by the size of ipv6 ICMP packet. */ - ASSERT_EQ(bytes, packets * 104, "bytes"); + ASSERT_GE(bytes, packets * 104, "bytes"); err: if (cg_fd != -1)
Change netcnt to demand at least 10K packets, as we frequently see some stray packet arriving during the test in BPF CI. It seems more important to make sure we haven't lost any packet than enforcing exact number of packets. Cc: Stanislav Fomichev <sdf@google.com> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> --- tools/testing/selftests/bpf/prog_tests/netcnt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)