| Message ID | 20230516073854.91742-1-m.migliore@tiesse.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1323e0c6e1d7e103d59384c3ac50f72b17a6936c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: dsa: mv88e6xxx: Fix mv88e6393x EPC write command offset | expand |
On Tue, May 16, 2023 at 09:38:54AM +0200, Marco Migliore wrote: > According to datasheet, the command opcode must be specified > into bits [14:12] of the Extended Port Control register (EPC). > > Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family") > Signed-off-by: Marco Migliore <m.migliore@tiesse.com> Hi Marco Thanks for the respin. Reviewed-by: Andrew Lunn <andrew@lunn.ch> For the next time you submit a patch, it is normal to put a version in the Subject line: [PATCH net v2] net: dsa: mv88e6xxx: Fix mv88e6393x EPC write command offset That helps us keep track of the versions, and makes it clear which is the latest version. Andrew
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 16 May 2023 09:38:54 +0200 you wrote: > According to datasheet, the command opcode must be specified > into bits [14:12] of the Extended Port Control register (EPC). > > Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family") > Signed-off-by: Marco Migliore <m.migliore@tiesse.com> > --- > drivers/net/dsa/mv88e6xxx/port.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net] net: dsa: mv88e6xxx: Fix mv88e6393x EPC write command offset https://git.kernel.org/netdev/net/c/1323e0c6e1d7 You are awesome, thank you!
diff --git a/drivers/net/dsa/mv88e6xxx/port.h b/drivers/net/dsa/mv88e6xxx/port.h index aec9d4fd20e3..d19b6303b91f 100644 --- a/drivers/net/dsa/mv88e6xxx/port.h +++ b/drivers/net/dsa/mv88e6xxx/port.h @@ -276,7 +276,7 @@ /* Offset 0x10: Extended Port Control Command */ #define MV88E6393X_PORT_EPC_CMD 0x10 #define MV88E6393X_PORT_EPC_CMD_BUSY 0x8000 -#define MV88E6393X_PORT_EPC_CMD_WRITE 0x0300 +#define MV88E6393X_PORT_EPC_CMD_WRITE 0x3000 #define MV88E6393X_PORT_EPC_INDEX_PORT_ETYPE 0x02 /* Offset 0x11: Extended Port Control Data */
According to datasheet, the command opcode must be specified into bits [14:12] of the Extended Port Control register (EPC). Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family") Signed-off-by: Marco Migliore <m.migliore@tiesse.com> --- drivers/net/dsa/mv88e6xxx/port.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)