| Message ID | 20230520172104.359597-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | efc3001f8b44bf5da0f178bd726a73c73f370707 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] nfc: Switch i2c drivers back to use .probe() | expand |
On Sat, 20 May 2023 19:21:04 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") > convert back to (the new) .probe() to be able to eventually drop > .probe_new() from struct i2c_driver. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Sat, 20 May 2023 19:21:04 +0200 you wrote: > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") > convert back to (the new) .probe() to be able to eventually drop > .probe_new() from struct i2c_driver. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > [...] Here is the summary with links: - [net-next] nfc: Switch i2c drivers back to use .probe() https://git.kernel.org/netdev/net-next/c/efc3001f8b44 You are awesome, thank you!
On Sat, 20 May 2023 19:21:04 +0200, Uwe Kleine-König wrote: > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type"), all drivers being converted to .probe_new() and then > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") > convert back to (the new) .probe() to be able to eventually drop > .probe_new() from struct i2c_driver. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Hello, > > this patch was generated using coccinelle, but I aligned the result to > the per-file indention. > > This is one patch for the whole iio subsystem. if you want it split per s/iio/nfc/ > driver for improved patch count numbers, please tell me. > > This currently fits on top of 6.4-rc1 and next/master. If you apply it > somewhere else and get conflicts, feel free to just drop the files with > conflicts from this patch and apply anyhow. I'll care about the fallout > later then. > > Best regards > Uwe > > drivers/nfc/fdp/i2c.c | 2 +- > drivers/nfc/microread/i2c.c | 2 +- > drivers/nfc/nfcmrvl/i2c.c | 2 +- > drivers/nfc/nxp-nci/i2c.c | 2 +- > drivers/nfc/pn533/i2c.c | 2 +- > drivers/nfc/pn544/i2c.c | 2 +- > drivers/nfc/s3fwrn5/i2c.c | 2 +- > drivers/nfc/st-nci/i2c.c | 2 +- > drivers/nfc/st21nfca/i2c.c | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) > (...) Reviewed-by: Jean Delvare <jdelvare@suse.de>
Hello Jean, On Wed, May 24, 2023 at 01:10:11PM +0200, Jean Delvare wrote: > On Sat, 20 May 2023 19:21:04 +0200, Uwe Kleine-König wrote: > > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > > call-back type"), all drivers being converted to .probe_new() and then > > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") > > convert back to (the new) .probe() to be able to eventually drop > > .probe_new() from struct i2c_driver. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > Hello, > > > > this patch was generated using coccinelle, but I aligned the result to > > the per-file indention. > > > > This is one patch for the whole iio subsystem. if you want it split per > > s/iio/nfc/ Yeah, copy&paste failure. I noticed after sending out the patch, but as it's only in a part of the mail that doesn't make it into git I didn't care to point it out. > > driver for improved patch count numbers, please tell me. > > > > This currently fits on top of 6.4-rc1 and next/master. If you apply it > > somewhere else and get conflicts, feel free to just drop the files with > > conflicts from this patch and apply anyhow. I'll care about the fallout > > later then. > > > > Best regards > > Uwe > > > > drivers/nfc/fdp/i2c.c | 2 +- > > drivers/nfc/microread/i2c.c | 2 +- > > drivers/nfc/nfcmrvl/i2c.c | 2 +- > > drivers/nfc/nxp-nci/i2c.c | 2 +- > > drivers/nfc/pn533/i2c.c | 2 +- > > drivers/nfc/pn544/i2c.c | 2 +- > > drivers/nfc/s3fwrn5/i2c.c | 2 +- > > drivers/nfc/st-nci/i2c.c | 2 +- > > drivers/nfc/st21nfca/i2c.c | 2 +- > > 9 files changed, 9 insertions(+), 9 deletions(-) > > (...) > > Reviewed-by: Jean Delvare <jdelvare@suse.de> Thanks, but note that davem already applied the patch, so your tag probably won't make it in. Best regards Uwe
diff --git a/drivers/nfc/fdp/i2c.c b/drivers/nfc/fdp/i2c.c index 1e0f2297f9c6..c1896a1d978c 100644 --- a/drivers/nfc/fdp/i2c.c +++ b/drivers/nfc/fdp/i2c.c @@ -359,7 +359,7 @@ static struct i2c_driver fdp_nci_i2c_driver = { .name = FDP_I2C_DRIVER_NAME, .acpi_match_table = fdp_nci_i2c_acpi_match, }, - .probe_new = fdp_nci_i2c_probe, + .probe = fdp_nci_i2c_probe, .remove = fdp_nci_i2c_remove, }; module_i2c_driver(fdp_nci_i2c_driver); diff --git a/drivers/nfc/microread/i2c.c b/drivers/nfc/microread/i2c.c index e72b358a2a12..642df4e0ce24 100644 --- a/drivers/nfc/microread/i2c.c +++ b/drivers/nfc/microread/i2c.c @@ -286,7 +286,7 @@ static struct i2c_driver microread_i2c_driver = { .driver = { .name = MICROREAD_I2C_DRIVER_NAME, }, - .probe_new = microread_i2c_probe, + .probe = microread_i2c_probe, .remove = microread_i2c_remove, .id_table = microread_i2c_id, }; diff --git a/drivers/nfc/nfcmrvl/i2c.c b/drivers/nfc/nfcmrvl/i2c.c index 164e2ab859fd..74553134c1b1 100644 --- a/drivers/nfc/nfcmrvl/i2c.c +++ b/drivers/nfc/nfcmrvl/i2c.c @@ -258,7 +258,7 @@ static const struct i2c_device_id nfcmrvl_i2c_id_table[] = { MODULE_DEVICE_TABLE(i2c, nfcmrvl_i2c_id_table); static struct i2c_driver nfcmrvl_i2c_driver = { - .probe_new = nfcmrvl_i2c_probe, + .probe = nfcmrvl_i2c_probe, .id_table = nfcmrvl_i2c_id_table, .remove = nfcmrvl_i2c_remove, .driver = { diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c index d4c299be7949..baddaf242d18 100644 --- a/drivers/nfc/nxp-nci/i2c.c +++ b/drivers/nfc/nxp-nci/i2c.c @@ -348,7 +348,7 @@ static struct i2c_driver nxp_nci_i2c_driver = { .acpi_match_table = ACPI_PTR(acpi_id), .of_match_table = of_nxp_nci_i2c_match, }, - .probe_new = nxp_nci_i2c_probe, + .probe = nxp_nci_i2c_probe, .id_table = nxp_nci_i2c_id_table, .remove = nxp_nci_i2c_remove, }; diff --git a/drivers/nfc/pn533/i2c.c b/drivers/nfc/pn533/i2c.c index 1503a98f0405..438ab9553f7a 100644 --- a/drivers/nfc/pn533/i2c.c +++ b/drivers/nfc/pn533/i2c.c @@ -259,7 +259,7 @@ static struct i2c_driver pn533_i2c_driver = { .name = PN533_I2C_DRIVER_NAME, .of_match_table = of_match_ptr(of_pn533_i2c_match), }, - .probe_new = pn533_i2c_probe, + .probe = pn533_i2c_probe, .id_table = pn533_i2c_id_table, .remove = pn533_i2c_remove, }; diff --git a/drivers/nfc/pn544/i2c.c b/drivers/nfc/pn544/i2c.c index 8b0d910bee06..3f6d74832bac 100644 --- a/drivers/nfc/pn544/i2c.c +++ b/drivers/nfc/pn544/i2c.c @@ -953,7 +953,7 @@ static struct i2c_driver pn544_hci_i2c_driver = { .of_match_table = of_match_ptr(of_pn544_i2c_match), .acpi_match_table = ACPI_PTR(pn544_hci_i2c_acpi_match), }, - .probe_new = pn544_hci_i2c_probe, + .probe = pn544_hci_i2c_probe, .id_table = pn544_hci_i2c_id_table, .remove = pn544_hci_i2c_remove, }; diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fwrn5/i2c.c index 2517ae71f9a4..720d4a72493c 100644 --- a/drivers/nfc/s3fwrn5/i2c.c +++ b/drivers/nfc/s3fwrn5/i2c.c @@ -261,7 +261,7 @@ static struct i2c_driver s3fwrn5_i2c_driver = { .name = S3FWRN5_I2C_DRIVER_NAME, .of_match_table = of_match_ptr(of_s3fwrn5_i2c_match), }, - .probe_new = s3fwrn5_i2c_probe, + .probe = s3fwrn5_i2c_probe, .remove = s3fwrn5_i2c_remove, .id_table = s3fwrn5_i2c_id_table, }; diff --git a/drivers/nfc/st-nci/i2c.c b/drivers/nfc/st-nci/i2c.c index 6b5eed8a1fbe..d20a337e90b4 100644 --- a/drivers/nfc/st-nci/i2c.c +++ b/drivers/nfc/st-nci/i2c.c @@ -283,7 +283,7 @@ static struct i2c_driver st_nci_i2c_driver = { .of_match_table = of_match_ptr(of_st_nci_i2c_match), .acpi_match_table = ACPI_PTR(st_nci_i2c_acpi_match), }, - .probe_new = st_nci_i2c_probe, + .probe = st_nci_i2c_probe, .id_table = st_nci_i2c_id_table, .remove = st_nci_i2c_remove, }; diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c index 55f7a2391bb1..064a63db288b 100644 --- a/drivers/nfc/st21nfca/i2c.c +++ b/drivers/nfc/st21nfca/i2c.c @@ -597,7 +597,7 @@ static struct i2c_driver st21nfca_hci_i2c_driver = { .of_match_table = of_match_ptr(of_st21nfca_i2c_match), .acpi_match_table = ACPI_PTR(st21nfca_hci_i2c_acpi_match), }, - .probe_new = st21nfca_hci_i2c_probe, + .probe = st21nfca_hci_i2c_probe, .id_table = st21nfca_hci_i2c_id_table, .remove = st21nfca_hci_i2c_remove, };
After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able to eventually drop .probe_new() from struct i2c_driver. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, this patch was generated using coccinelle, but I aligned the result to the per-file indention. This is one patch for the whole iio subsystem. if you want it split per driver for improved patch count numbers, please tell me. This currently fits on top of 6.4-rc1 and next/master. If you apply it somewhere else and get conflicts, feel free to just drop the files with conflicts from this patch and apply anyhow. I'll care about the fallout later then. Best regards Uwe drivers/nfc/fdp/i2c.c | 2 +- drivers/nfc/microread/i2c.c | 2 +- drivers/nfc/nfcmrvl/i2c.c | 2 +- drivers/nfc/nxp-nci/i2c.c | 2 +- drivers/nfc/pn533/i2c.c | 2 +- drivers/nfc/pn544/i2c.c | 2 +- drivers/nfc/s3fwrn5/i2c.c | 2 +- drivers/nfc/st-nci/i2c.c | 2 +- drivers/nfc/st21nfca/i2c.c | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) base-commit: ac9a78681b921877518763ba0e89202254349d1b