| Message ID | 20230524130127.268201-3-alexis.lothore@bootlin.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: mv88e6xxx: add 88E6361 support | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Posting correctly formatted |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 8 this patch: 8 |
| netdev/cc_maintainers | success | CCed 9 of 9 maintainers |
| netdev/build_clang | success | Errors and warnings before: 8 this patch: 8 |
| netdev/verify_signedoff | fail | author Signed-off-by missing |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 8 this patch: 8 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 35 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Wed, May 24, 2023 at 03:01:22PM +0200, Alexis Lothoré wrote: > Since this function is a simple helper, we do not need to pass a full > dsa_switch structure, we can directly pass the mv88e6xxx_chip structure. > Doing so will allow to share this function with any other function > not manipulating dsa_switch structure but needing info about number of > internal phys > > Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > > --- > Changes since v2: > - add reviewed-by tags > > Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com> > --- It never ceases to amaze me the way human beings can find creative ways to mess things up, no matter how well things are documented. The above commit message (and the others that I've looked at) are all broken because of this creativity. In effect, because of the really weird format you've come up with here, your patches are in effect *not* signed off by you. The patch format is in Documentation/process/submitting-patches.rst under the section marked "The canonical patch format". Please review. Please wait a while (a few days) to see if anyone responds to _this_ posting with any other comments. Thanks.
Hello Russell, On 5/24/23 15:18, Russell King (Oracle) wrote: > On Wed, May 24, 2023 at 03:01:22PM +0200, Alexis Lothoré wrote: >> Since this function is a simple helper, we do not need to pass a full >> dsa_switch structure, we can directly pass the mv88e6xxx_chip structure. >> Doing so will allow to share this function with any other function >> not manipulating dsa_switch structure but needing info about number of >> internal phys >> >> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> >> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> >> >> --- >> Changes since v2: >> - add reviewed-by tags >> >> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com> >> --- > > It never ceases to amaze me the way human beings can find creative ways > to mess things up, no matter how well things are documented. The above > commit message (and the others that I've looked at) are all broken > because of this creativity. > > In effect, because of the really weird format you've come up with here, > your patches are in effect *not* signed off by you. Sorry for that. This was an attempt to provide relevant changelog for each patch, but obviously the way I stored those changelogs was wrong, and I did not catch the consequent broken Signed-off-by lines after re-generating the series. I'll do as suggested and hold off a bit before fixing/re-sending. Kind regards, > > The patch format is in Documentation/process/submitting-patches.rst > under the section marked "The canonical patch format". Please review. > > Please wait a while (a few days) to see if anyone responds to _this_ > posting with any other comments. Thanks. >
On Wed, May 24, 2023 at 04:46:35PM +0200, Alexis Lothoré wrote: > Hello Russell, > > On 5/24/23 15:18, Russell King (Oracle) wrote: > > On Wed, May 24, 2023 at 03:01:22PM +0200, Alexis Lothoré wrote: > >> Since this function is a simple helper, we do not need to pass a full > >> dsa_switch structure, we can directly pass the mv88e6xxx_chip structure. > >> Doing so will allow to share this function with any other function > >> not manipulating dsa_switch structure but needing info about number of > >> internal phys > >> > >> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > >> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > >> > >> --- > >> Changes since v2: > >> - add reviewed-by tags > >> > >> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com> > >> --- > > > > It never ceases to amaze me the way human beings can find creative ways > > to mess things up, no matter how well things are documented. The above > > commit message (and the others that I've looked at) are all broken > > because of this creativity. > > > > In effect, because of the really weird format you've come up with here, > > your patches are in effect *not* signed off by you. > > Sorry for that. This was an attempt to provide relevant changelog for each > patch, but obviously the way I stored those changelogs was wrong, and I did not > catch the consequent broken Signed-off-by lines after re-generating the series. > I'll do as suggested and hold off a bit before fixing/re-sending. You can put the changelog in the commit message in git commit, you just need to add the correct --- separate after the tags. The patch created with git format-patch will then have two ---, but that is not a problem. Andrew --- pw-bot: cr
On 5/24/23 19:08, Andrew Lunn wrote: > On Wed, May 24, 2023 at 04:46:35PM +0200, Alexis Lothoré wrote: >> Hello Russell, >> >> On 5/24/23 15:18, Russell King (Oracle) wrote: >>> On Wed, May 24, 2023 at 03:01:22PM +0200, Alexis Lothoré wrote: >>>> Since this function is a simple helper, we do not need to pass a full >>>> dsa_switch structure, we can directly pass the mv88e6xxx_chip structure. >>>> Doing so will allow to share this function with any other function >>>> not manipulating dsa_switch structure but needing info about number of >>>> internal phys >>>> >>>> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> >>>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> >>>> >>>> --- >>>> Changes since v2: >>>> - add reviewed-by tags >>>> >>>> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com> >>>> --- >>> >>> It never ceases to amaze me the way human beings can find creative ways >>> to mess things up, no matter how well things are documented. The above >>> commit message (and the others that I've looked at) are all broken >>> because of this creativity. >>> >>> In effect, because of the really weird format you've come up with here, >>> your patches are in effect *not* signed off by you. >> >> Sorry for that. This was an attempt to provide relevant changelog for each >> patch, but obviously the way I stored those changelogs was wrong, and I did not >> catch the consequent broken Signed-off-by lines after re-generating the series. >> I'll do as suggested and hold off a bit before fixing/re-sending. > > You can put the changelog in the commit message in git commit, you > just need to add the correct --- separate after the tags. The patch > created with git format-patch will then have two ---, but that is not > a problem. Yes, that is exactly what I intended to do, but digging a bit, I guess the issue has been that my current configuration relies on git format-patch to insert my SoB, and it seems to not identify the marker so it inserts the SoB after it instead of before. Looks like it was broken in the series v2 too. Fixed my configuration to sign-off right at commit time. Thanks > > Andrew > > --- > pw-bot: cr
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 64a2f2f83735..93bcfa5c80e1 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -463,10 +463,8 @@ static int mv88e6xxx_port_setup_mac(struct mv88e6xxx_chip *chip, int port, return err; } -static int mv88e6xxx_phy_is_internal(struct dsa_switch *ds, int port) +static int mv88e6xxx_phy_is_internal(struct mv88e6xxx_chip *chip, int port) { - struct mv88e6xxx_chip *chip = ds->priv; - return port < chip->info->num_internal_phys; } @@ -584,7 +582,7 @@ static void mv88e6095_phylink_get_caps(struct mv88e6xxx_chip *chip, int port, config->mac_capabilities = MAC_SYM_PAUSE | MAC_10 | MAC_100; - if (mv88e6xxx_phy_is_internal(chip->ds, port)) { + if (mv88e6xxx_phy_is_internal(chip, port)) { __set_bit(PHY_INTERFACE_MODE_MII, config->supported_interfaces); } else { if (cmode < ARRAY_SIZE(mv88e6185_phy_interface_modes) && @@ -832,7 +830,7 @@ static void mv88e6xxx_get_caps(struct dsa_switch *ds, int port, chip->info->ops->phylink_get_caps(chip, port, config); mv88e6xxx_reg_unlock(chip); - if (mv88e6xxx_phy_is_internal(ds, port)) { + if (mv88e6xxx_phy_is_internal(chip, port)) { __set_bit(PHY_INTERFACE_MODE_INTERNAL, config->supported_interfaces); /* Internal ports with no phy-mode need GMII for PHYLIB */ @@ -853,7 +851,7 @@ static void mv88e6xxx_mac_config(struct dsa_switch *ds, int port, mv88e6xxx_reg_lock(chip); - if (mode != MLO_AN_PHY || !mv88e6xxx_phy_is_internal(ds, port)) { + if (mode != MLO_AN_PHY || !mv88e6xxx_phy_is_internal(chip, port)) { /* In inband mode, the link may come up at any time while the * link is not forced down. Force the link down while we * reconfigure the interface mode.