diff mbox series

[net-next] tcp: remove unused TCP_SYNQ_INTERVAL definition

Message ID 20230525145736.2151925-1-ncardwell.sw@gmail.com (mailing list archive)
State Accepted
Commit f26f03b3031938ad46c3fb617745e9fd4a289ce7
Delegated to: Netdev Maintainers
Headers show
Series [net-next] tcp: remove unused TCP_SYNQ_INTERVAL definition | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next, async
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1013 this patch: 1013
netdev/cc_maintainers warning 1 maintainers not CCed: pabeni@redhat.com
netdev/build_clang success Errors and warnings before: 127 this patch: 127
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1020 this patch: 1020
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Neal Cardwell May 25, 2023, 2:57 p.m. UTC 
From: Neal Cardwell <ncardwell@google.com>

Currently TCP_SYNQ_INTERVAL is defined but never used.

According to "git log -S TCP_SYNQ_INTERVAL net-next/main" it seems
the last references to TCP_SYNQ_INTERVAL were removed by 2015
commit fa76ce7328b2 ("inet: get rid of central tcp/dccp listener timer")

Signed-off-by: Neal Cardwell <ncardwell@google.com>
---
 include/net/tcp.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Simon Horman May 26, 2023, 9:29 a.m. UTC | #1 
+ missing maintainer, Paolo.

On Thu, May 25, 2023 at 10:57:36AM -0400, Neal Cardwell wrote:
> From: Neal Cardwell <ncardwell@google.com>
> 
> Currently TCP_SYNQ_INTERVAL is defined but never used.
> 
> According to "git log -S TCP_SYNQ_INTERVAL net-next/main" it seems
> the last references to TCP_SYNQ_INTERVAL were removed by 2015
> commit fa76ce7328b2 ("inet: get rid of central tcp/dccp listener timer")
> 
> Signed-off-by: Neal Cardwell <ncardwell@google.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Eric Dumazet May 26, 2023, 9:45 a.m. UTC | #2 
On Thu, May 25, 2023 at 4:57 PM Neal Cardwell <ncardwell.sw@gmail.com> wrote:
>
> From: Neal Cardwell <ncardwell@google.com>
>
> Currently TCP_SYNQ_INTERVAL is defined but never used.
>
> According to "git log -S TCP_SYNQ_INTERVAL net-next/main" it seems
> the last references to TCP_SYNQ_INTERVAL were removed by 2015
> commit fa76ce7328b2 ("inet: get rid of central tcp/dccp listener timer")
>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@google.com>

Someone is cleaning up packetdrill tests ;)
patchwork-bot+netdevbpf@kernel.org May 26, 2023, 10:40 a.m. UTC | #3 
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 25 May 2023 10:57:36 -0400 you wrote:
> From: Neal Cardwell <ncardwell@google.com>
> 
> Currently TCP_SYNQ_INTERVAL is defined but never used.
> 
> According to "git log -S TCP_SYNQ_INTERVAL net-next/main" it seems
> the last references to TCP_SYNQ_INTERVAL were removed by 2015
> commit fa76ce7328b2 ("inet: get rid of central tcp/dccp listener timer")
> 
> [...]

Here is the summary with links:
  - [net-next] tcp: remove unused TCP_SYNQ_INTERVAL definition
    https://git.kernel.org/netdev/net-next/c/f26f03b30319

You are awesome, thank you!
diff mbox series

Patch

diff --git a/include/net/tcp.h b/include/net/tcp.h
index 02a6cff1827e..8123de1e0db9 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -161,8 +161,6 @@  void tcp_time_wait(struct sock *sk, int state, int timeo);
 #define MAX_TCP_KEEPCNT		127
 #define MAX_TCP_SYNCNT		127
 
-#define TCP_SYNQ_INTERVAL	(HZ/5)	/* Period of SYNACK timer */
-
 #define TCP_PAWS_24DAYS	(60 * 60 * 24 * 24)
 #define TCP_PAWS_MSL	60		/* Per-host timestamps are invalidated
 					 * after this time. It should be equal