| Message ID | 20230529114835.372140-3-idosch@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d5ccfd90df7fd0a50038a68634c131b8fd081bac |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add layer 2 miss indication and filtering | expand |
On 29/05/2023 14:48, Ido Schimmel wrote: > Extend the 'FLOW_DISSECTOR_KEY_META' key with a new 'l2_miss' field and > populate it from a field with the same name in the tc skb extension. > This field is set by the bridge driver for packets that incur an FDB or > MDB miss. > > The next patch will extend the flower classifier to be able to match on > layer 2 misses. > > Signed-off-by: Ido Schimmel <idosch@nvidia.com> > --- > > Notes: > v2: > * Split from flower patch. > * Use tc skb extension instead of 'skb->l2_miss'. > > include/net/flow_dissector.h | 2 ++ > net/core/flow_dissector.c | 10 ++++++++++ > 2 files changed, 12 insertions(+) > Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h index 85b2281576ed..8b41668c77fc 100644 --- a/include/net/flow_dissector.h +++ b/include/net/flow_dissector.h @@ -243,10 +243,12 @@ struct flow_dissector_key_ip { * struct flow_dissector_key_meta: * @ingress_ifindex: ingress ifindex * @ingress_iftype: ingress interface type + * @l2_miss: packet did not match an L2 entry during forwarding */ struct flow_dissector_key_meta { int ingress_ifindex; u16 ingress_iftype; + u8 l2_miss; }; /** diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 25fb0bbc310f..481ca4080cbd 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissector.c @@ -27,6 +27,7 @@ #include <linux/tcp.h> #include <linux/ptp_classify.h> #include <net/flow_dissector.h> +#include <net/pkt_cls.h> #include <scsi/fc/fc_fcoe.h> #include <uapi/linux/batadv_packet.h> #include <linux/bpf.h> @@ -241,6 +242,15 @@ void skb_flow_dissect_meta(const struct sk_buff *skb, FLOW_DISSECTOR_KEY_META, target_container); meta->ingress_ifindex = skb->skb_iif; +#if IS_ENABLED(CONFIG_NET_TC_SKB_EXT) + if (tc_skb_ext_tc_enabled()) { + struct tc_skb_ext *ext; + + ext = skb_ext_find(skb, TC_SKB_EXT); + if (ext) + meta->l2_miss = ext->l2_miss; + } +#endif } EXPORT_SYMBOL(skb_flow_dissect_meta);
Extend the 'FLOW_DISSECTOR_KEY_META' key with a new 'l2_miss' field and populate it from a field with the same name in the tc skb extension. This field is set by the bridge driver for packets that incur an FDB or MDB miss. The next patch will extend the flower classifier to be able to match on layer 2 misses. Signed-off-by: Ido Schimmel <idosch@nvidia.com> --- Notes: v2: * Split from flower patch. * Use tc skb extension instead of 'skb->l2_miss'. include/net/flow_dissector.h | 2 ++ net/core/flow_dissector.c | 10 ++++++++++ 2 files changed, 12 insertions(+)