| Message ID | 20230530083713.2527380-2-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Extend dt-bindings for PSE-PD controllers and update prtt1c dts | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 30/05/2023 10:37, Oleksij Rempel wrote: > This patch modifies the regex pattern for the $nodename property in the Please do not use "This commit/patch", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > device tree bindings documentation for PSE-PD controllers. The updated > pattern allows for additional node names, including those with a hyphen > followed by a hexadecimal digit. > > Before this change, the pattern ^ethernet-pse(@.*)?$ only allowed for > node names like "ethernet-pse" or "ethernet-pse@1". With the new pattern > node names like "ethernet-pse-1" are now also valid. This part is duplicating first paragraph. What you should have here is answer to why we need it. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/net/pse-pd/pse-controller.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml > index b110abb42597..3548efc2191c 100644 > --- a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml > +++ b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml > @@ -16,7 +16,7 @@ maintainers: > > properties: > $nodename: > - pattern: "^ethernet-pse(@.*)?$" > + pattern: "^ethernet-pse(@[0-9a-f]+|-([0-9a-f]+))?$" No need for inner () Let's make -N suffix only decimal, as discussed here: https://lore.kernel.org/all/20221123024153.GB1026269-robh@kernel.org/ I will send a patch for other files. > > "#pse-cells": > description: Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml index b110abb42597..3548efc2191c 100644 --- a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml +++ b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml @@ -16,7 +16,7 @@ maintainers: properties: $nodename: - pattern: "^ethernet-pse(@.*)?$" + pattern: "^ethernet-pse(@[0-9a-f]+|-([0-9a-f]+))?$" "#pse-cells": description:
This patch modifies the regex pattern for the $nodename property in the device tree bindings documentation for PSE-PD controllers. The updated pattern allows for additional node names, including those with a hyphen followed by a hexadecimal digit. Before this change, the pattern ^ethernet-pse(@.*)?$ only allowed for node names like "ethernet-pse" or "ethernet-pse@1". With the new pattern node names like "ethernet-pse-1" are now also valid. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- .../devicetree/bindings/net/pse-pd/pse-controller.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)