| Message ID | 20230601172145.51357-4-stephen@networkplumber.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | localize functions where possible | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 01/06/2023 20:21, Stephen Hemminger wrote: > Function defined and used in only one file. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > --- > bridge/br_common.h | 1 - > bridge/vlan.c | 3 ++- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bridge/br_common.h b/bridge/br_common.h > index 1bdee65844c1..704e76b0acb2 100644 > --- a/bridge/br_common.h > +++ b/bridge/br_common.h > @@ -6,7 +6,6 @@ > #define MDB_RTR_RTA(r) \ > ((struct rtattr *)(((char *)(r)) + RTA_ALIGN(sizeof(__u32)))) > > -void print_vlan_info(struct rtattr *tb, int ifindex); > int print_linkinfo(struct nlmsghdr *n, void *arg); > int print_mdb_mon(struct nlmsghdr *n, void *arg); > int print_fdb(struct nlmsghdr *n, void *arg); > diff --git a/bridge/vlan.c b/bridge/vlan.c > index 5b304ea94224..dfc62f83a5df 100644 > --- a/bridge/vlan.c > +++ b/bridge/vlan.c > @@ -18,6 +18,7 @@ > > static unsigned int filter_index, filter_vlan; > static int vlan_rtm_cur_ifidx = -1; > +static void print_vlan_info(struct rtattr *tb, int ifindex); > > enum vlan_show_subject { > VLAN_SHOW_VLAN, > @@ -1309,7 +1310,7 @@ static int vlan_global_show(int argc, char **argv) > return 0; > } > > -void print_vlan_info(struct rtattr *tb, int ifindex) > +static void print_vlan_info(struct rtattr *tb, int ifindex) > { > struct rtattr *i, *list = tb; > int rem = RTA_PAYLOAD(list); Thanks, Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
diff --git a/bridge/br_common.h b/bridge/br_common.h index 1bdee65844c1..704e76b0acb2 100644 --- a/bridge/br_common.h +++ b/bridge/br_common.h @@ -6,7 +6,6 @@ #define MDB_RTR_RTA(r) \ ((struct rtattr *)(((char *)(r)) + RTA_ALIGN(sizeof(__u32)))) -void print_vlan_info(struct rtattr *tb, int ifindex); int print_linkinfo(struct nlmsghdr *n, void *arg); int print_mdb_mon(struct nlmsghdr *n, void *arg); int print_fdb(struct nlmsghdr *n, void *arg); diff --git a/bridge/vlan.c b/bridge/vlan.c index 5b304ea94224..dfc62f83a5df 100644 --- a/bridge/vlan.c +++ b/bridge/vlan.c @@ -18,6 +18,7 @@ static unsigned int filter_index, filter_vlan; static int vlan_rtm_cur_ifidx = -1; +static void print_vlan_info(struct rtattr *tb, int ifindex); enum vlan_show_subject { VLAN_SHOW_VLAN, @@ -1309,7 +1310,7 @@ static int vlan_global_show(int argc, char **argv) return 0; } -void print_vlan_info(struct rtattr *tb, int ifindex) +static void print_vlan_info(struct rtattr *tb, int ifindex) { struct rtattr *i, *list = tb; int rem = RTA_PAYLOAD(list);
Function defined and used in only one file. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- bridge/br_common.h | 1 - bridge/vlan.c | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-)