| Message ID | 20230602030842.279262-1-gongruiqi@huaweicloud.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | BPF |
| Headers | show |
| Series | bpf: cleanup unused function declaration | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
| bpf/vmtest-bpf-next-VM_Test-26 | success | Logs for test_verifier on s390x with gcc |
| bpf/vmtest-bpf-next-VM_Test-12 | success | Logs for test_progs on s390x with gcc |
| bpf/vmtest-bpf-next-VM_Test-16 | success | Logs for test_progs_no_alu32 on s390x with gcc |
| bpf/vmtest-bpf-next-PR | fail | PR summary |
| bpf/vmtest-bpf-next-VM_Test-8 | success | Logs for test_maps on s390x with gcc |
| bpf/vmtest-bpf-next-VM_Test-1 | success | Logs for ShellCheck |
| bpf/vmtest-bpf-next-VM_Test-2 | success | Logs for build for aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-4 | success | Logs for build for x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-5 | success | Logs for build for x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-6 | success | Logs for set-matrix |
| bpf/vmtest-bpf-next-VM_Test-3 | success | Logs for build for s390x with gcc |
| bpf/vmtest-bpf-next-VM_Test-7 | success | Logs for test_maps on aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-9 | success | Logs for test_maps on x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-10 | success | Logs for test_maps on x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-19 | success | Logs for test_progs_no_alu32_parallel on aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-20 | success | Logs for test_progs_no_alu32_parallel on x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-21 | success | Logs for test_progs_no_alu32_parallel on x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-22 | success | Logs for test_progs_parallel on aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-23 | success | Logs for test_progs_parallel on x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-24 | success | Logs for test_progs_parallel on x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-25 | success | Logs for test_verifier on aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-27 | success | Logs for test_verifier on x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-28 | success | Logs for test_verifier on x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-29 | success | Logs for veristat |
| bpf/vmtest-bpf-next-VM_Test-11 | success | Logs for test_progs on aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-13 | success | Logs for test_progs on x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-14 | success | Logs for test_progs on x86_64 with llvm-16 |
| bpf/vmtest-bpf-next-VM_Test-15 | success | Logs for test_progs_no_alu32 on aarch64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-17 | success | Logs for test_progs_no_alu32 on x86_64 with gcc |
| bpf/vmtest-bpf-next-VM_Test-18 | success | Logs for test_progs_no_alu32 on x86_64 with llvm-16 |
On 06/02, GONG, Ruiqi wrote: > All usage and the definition of `bpf_prog_free_linfo()` has been removed > in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and > jited_linfo"). Clean up its declaration in the header file. > > Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com> Acked-by: Stanislav Fomichev <sdf@google.com> > --- > include/linux/filter.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/filter.h b/include/linux/filter.h > index bbce89937fde..f69114083ec7 100644 > --- a/include/linux/filter.h > +++ b/include/linux/filter.h > @@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp); > > bool bpf_opcode_in_insntable(u8 code); > > -void bpf_prog_free_linfo(struct bpf_prog *prog); > void bpf_prog_fill_jited_linfo(struct bpf_prog *prog, > const u32 *insn_to_jit_off); > int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog); > -- > 2.25.1 >
On Fri, Jun 2, 2023 at 9:12 AM Stanislav Fomichev <sdf@google.com> wrote: > > On 06/02, GONG, Ruiqi wrote: > > All usage and the definition of `bpf_prog_free_linfo()` has been removed > > in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and > > jited_linfo"). Clean up its declaration in the header file. > > > > Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com> > I'm actually having trouble applying this locally. Can you please rebase against bpf-next/master and resend it? Also, please check Signed-off-by's "<first> <last> <email>" order and spelling. Should it be "Ruiqi Gong <...>"? > Acked-by: Stanislav Fomichev <sdf@google.com> > > > --- > > include/linux/filter.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/include/linux/filter.h b/include/linux/filter.h > > index bbce89937fde..f69114083ec7 100644 > > --- a/include/linux/filter.h > > +++ b/include/linux/filter.h > > @@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp); > > > > bool bpf_opcode_in_insntable(u8 code); > > > > -void bpf_prog_free_linfo(struct bpf_prog *prog); > > void bpf_prog_fill_jited_linfo(struct bpf_prog *prog, > > const u32 *insn_to_jit_off); > > int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog); > > -- > > 2.25.1 > >
diff --git a/include/linux/filter.h b/include/linux/filter.h index bbce89937fde..f69114083ec7 100644 --- a/include/linux/filter.h +++ b/include/linux/filter.h @@ -874,7 +874,6 @@ void bpf_prog_free(struct bpf_prog *fp); bool bpf_opcode_in_insntable(u8 code); -void bpf_prog_free_linfo(struct bpf_prog *prog); void bpf_prog_fill_jited_linfo(struct bpf_prog *prog, const u32 *insn_to_jit_off); int bpf_prog_alloc_jited_linfo(struct bpf_prog *prog);
All usage and the definition of `bpf_prog_free_linfo()` has been removed in commit e16301fbe183 ("bpf: Simplify freeing logic in linfo and jited_linfo"). Clean up its declaration in the header file. Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com> --- include/linux/filter.h | 1 - 1 file changed, 1 deletion(-)