diff mbox series

[net] netlink: specs: ethtool: fix random typos

Message ID 20230605233257.843977-1-kuba@kernel.org (mailing list archive)
State Accepted
Commit f6ca5baf2a86d0eaff3859844da9e4e29ff750a7
Delegated to: Netdev Maintainers
Headers show
Series [net] netlink: specs: ethtool: fix random typos | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 123 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Jakub Kicinski June 5, 2023, 11:32 p.m. UTC 
Working on the code gen for C reveals typos in the ethtool spec
as the compiler tries to find the names in the existing uAPI
header. Fix the mistakes.

Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: sdf@google.com
---
 Documentation/netlink/specs/ethtool.yaml | 32 ++++++++++++------------
 1 file changed, 16 insertions(+), 16 deletions(-)

Comments

Stanislav Fomichev June 5, 2023, 11:37 p.m. UTC | #1 
On Mon, Jun 5, 2023 at 4:33 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Working on the code gen for C reveals typos in the ethtool spec
> as the compiler tries to find the names in the existing uAPI
> header. Fix the mistakes.
>
> Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Stanislav Fomichev <sdf@google.com>

Ooopsie, thanks!

> ---
> CC: sdf@google.com
> ---
>  Documentation/netlink/specs/ethtool.yaml | 32 ++++++++++++------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 3abc576ff797..4846345bade4 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -223,7 +223,7 @@ doc: Partial family for Ethtool Netlink.
>          name: tx-min-frag-size
>          type: u32
>        -
> -        name: tx-min-frag-size
> +        name: rx-min-frag-size
>          type: u32
>        -
>          name: verify-enabled
> @@ -294,7 +294,7 @@ doc: Partial family for Ethtool Netlink.
>          name: master-slave-state
>          type: u8
>        -
> -        name: master-slave-lanes
> +        name: lanes
>          type: u32
>        -
>          name: rate-matching
> @@ -322,7 +322,7 @@ doc: Partial family for Ethtool Netlink.
>          name: ext-substate
>          type: u8
>        -
> -        name: down-cnt
> +        name: ext-down-cnt
>          type: u32
>    -
>      name: debug
> @@ -577,7 +577,7 @@ doc: Partial family for Ethtool Netlink.
>          name: phc-index
>          type: u32
>    -

[..]

> -    name: cable-test-nft-nest-result
> +    name: cable-test-ntf-nest-result
>      attributes:
>        -
>          name: pair
> @@ -586,7 +586,7 @@ doc: Partial family for Ethtool Netlink.
>          name: code
>          type: u8
>    -
> -    name: cable-test-nft-nest-fault-length
> +    name: cable-test-ntf-nest-fault-length
>      attributes:
>        -
>          name: pair
> @@ -595,16 +595,16 @@ doc: Partial family for Ethtool Netlink.
>          name: cm
>          type: u32
>    -
> -    name: cable-test-nft-nest
> +    name: cable-test-ntf-nest
>      attributes:
>        -
>          name: result
>          type: nest
> -        nested-attributes: cable-test-nft-nest-result
> +        nested-attributes: cable-test-ntf-nest-result
>        -
>          name: fault-length
>          type: nest
> -        nested-attributes: cable-test-nft-nest-fault-length
> +        nested-attributes: cable-test-ntf-nest-fault-length
>    -
>      name: cable-test
>      attributes:
> @@ -618,7 +618,7 @@ doc: Partial family for Ethtool Netlink.
>        -
>          name: nest
>          type: nest
> -        nested-attributes: cable-test-nft-nest
> +        nested-attributes: cable-test-ntf-nest

So much NFTs! Long live NFTs :-D
Jakub Kicinski June 6, 2023, 12:20 a.m. UTC | #2 
On Mon, 5 Jun 2023 16:37:26 -0700 Stanislav Fomichev wrote:
> > -        nested-attributes: cable-test-nft-nest
> > +        nested-attributes: cable-test-ntf-nest  
> 
> So much NFTs! Long live NFTs :-D

Maybe if I named the patch "remove NFT references" we'd have made 
the news. Missed opportunity :D
patchwork-bot+netdevbpf@kernel.org June 7, 2023, 1:50 a.m. UTC | #3 
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  5 Jun 2023 16:32:57 -0700 you wrote:
> Working on the code gen for C reveals typos in the ethtool spec
> as the compiler tries to find the names in the existing uAPI
> header. Fix the mistakes.
> 
> Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> 
> [...]

Here is the summary with links:
  - [net] netlink: specs: ethtool: fix random typos
    https://git.kernel.org/netdev/net/c/f6ca5baf2a86

You are awesome, thank you!
diff mbox series

Patch

diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 3abc576ff797..4846345bade4 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -223,7 +223,7 @@  doc: Partial family for Ethtool Netlink.
         name: tx-min-frag-size
         type: u32
       -
-        name: tx-min-frag-size
+        name: rx-min-frag-size
         type: u32
       -
         name: verify-enabled
@@ -294,7 +294,7 @@  doc: Partial family for Ethtool Netlink.
         name: master-slave-state
         type: u8
       -
-        name: master-slave-lanes
+        name: lanes
         type: u32
       -
         name: rate-matching
@@ -322,7 +322,7 @@  doc: Partial family for Ethtool Netlink.
         name: ext-substate
         type: u8
       -
-        name: down-cnt
+        name: ext-down-cnt
         type: u32
   -
     name: debug
@@ -577,7 +577,7 @@  doc: Partial family for Ethtool Netlink.
         name: phc-index
         type: u32
   -
-    name: cable-test-nft-nest-result
+    name: cable-test-ntf-nest-result
     attributes:
       -
         name: pair
@@ -586,7 +586,7 @@  doc: Partial family for Ethtool Netlink.
         name: code
         type: u8
   -
-    name: cable-test-nft-nest-fault-length
+    name: cable-test-ntf-nest-fault-length
     attributes:
       -
         name: pair
@@ -595,16 +595,16 @@  doc: Partial family for Ethtool Netlink.
         name: cm
         type: u32
   -
-    name: cable-test-nft-nest
+    name: cable-test-ntf-nest
     attributes:
       -
         name: result
         type: nest
-        nested-attributes: cable-test-nft-nest-result
+        nested-attributes: cable-test-ntf-nest-result
       -
         name: fault-length
         type: nest
-        nested-attributes: cable-test-nft-nest-fault-length
+        nested-attributes: cable-test-ntf-nest-fault-length
   -
     name: cable-test
     attributes:
@@ -618,7 +618,7 @@  doc: Partial family for Ethtool Netlink.
       -
         name: nest
         type: nest
-        nested-attributes: cable-test-nft-nest
+        nested-attributes: cable-test-ntf-nest
   -
     name: cable-test-tdr-cfg
     attributes:
@@ -776,7 +776,7 @@  doc: Partial family for Ethtool Netlink.
         name: hist-bkt-hi
         type: u32
       -
-        name: hist-bkt-val
+        name: hist-val
         type: u64
   -
     name: stats
@@ -965,7 +965,7 @@  doc: Partial family for Ethtool Netlink.
             - duplex
             - master-slave-cfg
             - master-slave-state
-            - master-slave-lanes
+            - lanes
             - rate-matching
       dump: *linkmodes-get-op
     -
@@ -999,7 +999,7 @@  doc: Partial family for Ethtool Netlink.
             - sqi-max
             - ext-state
             - ext-substate
-            - down-cnt
+            - ext-down-cnt
       dump: *linkstate-get-op
     -
       name: debug-get
@@ -1351,7 +1351,7 @@  doc: Partial family for Ethtool Netlink.
         reply:
           attributes:
             - header
-            - cable-test-nft-nest
+            - cable-test-ntf-nest
     -
       name: cable-test-tdr-act
       doc: Cable test TDR.
@@ -1539,7 +1539,7 @@  doc: Partial family for Ethtool Netlink.
             - hkey
       dump: *rss-get-op
     -
-      name: plca-get
+      name: plca-get-cfg
       doc: Get PLCA params.
 
       attribute-set: plca
@@ -1561,7 +1561,7 @@  doc: Partial family for Ethtool Netlink.
             - burst-tmr
       dump: *plca-get-op
     -
-      name: plca-set
+      name: plca-set-cfg
       doc: Set PLCA params.
 
       attribute-set: plca
@@ -1585,7 +1585,7 @@  doc: Partial family for Ethtool Netlink.
     -
       name: plca-ntf
       doc: Notification for change in PLCA params.
-      notify: plca-get
+      notify: plca-get-cfg
     -
       name: mm-get
       doc: Get MAC Merge configuration and state