| Message ID | 20230606114233.4160703-1-edumazet@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 886bc7d6ed3357975c5f1d3c784da96000d4bbb4 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: sched: move rtm_tca_policy declaration to include file | expand |
On Tue, Jun 6, 2023 at 7:42 AM Eric Dumazet <edumazet@google.com> wrote: > > rtm_tca_policy is used from net/sched/sch_api.c and net/sched/cls_api.c, > thus should be declared in an include file. > > This fixes the following sparse warning: > net/sched/sch_api.c:1434:25: warning: symbol 'rtm_tca_policy' was not declared. Should it be static? > > Fixes: e331473fee3d ("net/sched: cls_api: add missing validation of netlink attributes") > Signed-off-by: Eric Dumazet <edumazet@google.com> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> cheers, jamal > include/net/pkt_sched.h | 2 ++ > net/sched/cls_api.c | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h > index f436688b6efc8f20ee5ede6ee94404e22bbebf3f..5722931d83d431d8cc625d44ba2bc22d88301d5b 100644 > --- a/include/net/pkt_sched.h > +++ b/include/net/pkt_sched.h > @@ -127,6 +127,8 @@ static inline void qdisc_run(struct Qdisc *q) > } > } > > +extern const struct nla_policy rtm_tca_policy[TCA_MAX + 1]; > + > /* Calculate maximal size of packet seen by hard_start_xmit > routine of this device. > */ > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c > index 2621550bfddc1e466b6a03b0ce6eb5de25ab7476..b2432ee04f3193f6bbcb7986fd950d470fd28e55 100644 > --- a/net/sched/cls_api.c > +++ b/net/sched/cls_api.c > @@ -43,8 +43,6 @@ > #include <net/flow_offload.h> > #include <net/tc_wrapper.h> > > -extern const struct nla_policy rtm_tca_policy[TCA_MAX + 1]; > - > /* The list of all installed classifier types */ > static LIST_HEAD(tcf_proto_base); > > -- > 2.41.0.rc0.172.g3f132b7071-goog >
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 6 Jun 2023 11:42:33 +0000 you wrote: > rtm_tca_policy is used from net/sched/sch_api.c and net/sched/cls_api.c, > thus should be declared in an include file. > > This fixes the following sparse warning: > net/sched/sch_api.c:1434:25: warning: symbol 'rtm_tca_policy' was not declared. Should it be static? > > Fixes: e331473fee3d ("net/sched: cls_api: add missing validation of netlink attributes") > Signed-off-by: Eric Dumazet <edumazet@google.com> > > [...] Here is the summary with links: - [net] net: sched: move rtm_tca_policy declaration to include file https://git.kernel.org/netdev/net/c/886bc7d6ed33 You are awesome, thank you!
diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h index f436688b6efc8f20ee5ede6ee94404e22bbebf3f..5722931d83d431d8cc625d44ba2bc22d88301d5b 100644 --- a/include/net/pkt_sched.h +++ b/include/net/pkt_sched.h @@ -127,6 +127,8 @@ static inline void qdisc_run(struct Qdisc *q) } } +extern const struct nla_policy rtm_tca_policy[TCA_MAX + 1]; + /* Calculate maximal size of packet seen by hard_start_xmit routine of this device. */ diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 2621550bfddc1e466b6a03b0ce6eb5de25ab7476..b2432ee04f3193f6bbcb7986fd950d470fd28e55 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -43,8 +43,6 @@ #include <net/flow_offload.h> #include <net/tc_wrapper.h> -extern const struct nla_policy rtm_tca_policy[TCA_MAX + 1]; - /* The list of all installed classifier types */ static LIST_HEAD(tcf_proto_base);
rtm_tca_policy is used from net/sched/sch_api.c and net/sched/cls_api.c, thus should be declared in an include file. This fixes the following sparse warning: net/sched/sch_api.c:1434:25: warning: symbol 'rtm_tca_policy' was not declared. Should it be static? Fixes: e331473fee3d ("net/sched: cls_api: add missing validation of netlink attributes") Signed-off-by: Eric Dumazet <edumazet@google.com> --- include/net/pkt_sched.h | 2 ++ net/sched/cls_api.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-)