| Message ID | 20230609085249.131071-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/3] net: hv_netvsc: Remove duplicated include in rndis_filter.c | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | warning | Series does not have a cover letter |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 8 this patch: 8 |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/build_clang | success | Errors and warnings before: 8 this patch: 8 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 8 this patch: 8 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 9 Jun 2023 16:52:47 +0800 you wrote: > ./tools/net/ynl/generated/devlink-user.c: stdlib.h is included more than once. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5464 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > tools/net/ynl/generated/devlink-user.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [net-next,3/3] tools: ynl: Remove duplicated include in devlink-user.c (no matching commit) - [net-next,2/3] tools: ynl: Remove duplicated include in handshake-user.c https://git.kernel.org/netdev/net-next/c/e7c5433c5aaa - [net-next,1/3] net: hv_netvsc: Remove duplicated include in rndis_filter.c (no matching commit) You are awesome, thank you!
Fri, Jun 09, 2023 at 10:52:47AM CEST, yang.lee@linux.alibaba.com wrote: >./tools/net/ynl/generated/devlink-user.c: stdlib.h is included more than once. > >Reported-by: Abaci Robot <abaci@linux.alibaba.com> >Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5464 >Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> >--- > tools/net/ynl/generated/devlink-user.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/tools/net/ynl/generated/devlink-user.c b/tools/net/ynl/generated/devlink-user.c >index c3204e20b971..18157afd7c73 100644 >--- a/tools/net/ynl/generated/devlink-user.c >+++ b/tools/net/ynl/generated/devlink-user.c You are patching generated file, as the path suggests. See what the file header says: /* Do not edit directly, auto-generated from: */ /* Documentation/netlink/specs/devlink.yaml */ >@@ -8,7 +8,6 @@ > #include "ynl.h" > #include <linux/devlink.h> > >-#include <stdlib.h> > #include <stdio.h> > #include <string.h> > #include <libmnl/libmnl.h> >-- >2.20.1.7.g153144c > >
On Fri, 9 Jun 2023 13:38:21 +0200 Jiri Pirko wrote: > You are patching generated file, as the path suggests. > See what the file header says: > /* Do not edit directly, auto-generated from: */ > /* Documentation/netlink/specs/devlink.yaml */ And the full fix is already on the list :( https://lore.kernel.org/all/20230608211200.1247213-2-kuba@kernel.org/ Reverted...
diff --git a/tools/net/ynl/generated/devlink-user.c b/tools/net/ynl/generated/devlink-user.c index c3204e20b971..18157afd7c73 100644 --- a/tools/net/ynl/generated/devlink-user.c +++ b/tools/net/ynl/generated/devlink-user.c @@ -8,7 +8,6 @@ #include "ynl.h" #include <linux/devlink.h> -#include <stdlib.h> #include <stdio.h> #include <string.h> #include <libmnl/libmnl.h>
./tools/net/ynl/generated/devlink-user.c: stdlib.h is included more than once. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5464 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- tools/net/ynl/generated/devlink-user.c | 1 - 1 file changed, 1 deletion(-)