diff mbox series

[net-next] selftests: forwarding: Fix layer 2 miss test syntax

Message ID 20230611112218.332298-1-idosch@nvidia.com (mailing list archive)
State Accepted
Commit c29e012eae29c13f092a95f1ffab40a269fe5bc2
Delegated to: Netdev Maintainers
Headers show
Series [net-next] selftests: forwarding: Fix layer 2 miss test syntax | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/cc_maintainers warning 2 maintainers not CCed: shuah@kernel.org linux-kselftest@vger.kernel.org
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success net selftest script(s) already in Makefile
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 46 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Ido Schimmel June 11, 2023, 11:22 a.m. UTC 
The test currently specifies "l2_miss" as "true" / "false", but the
version that eventually landed in iproute2 uses "1" / "0" [1]. Align the
test accordingly.

[1] https://lore.kernel.org/netdev/20230607153550.3829340-1-idosch@nvidia.com/

Fixes: 8c33266ae26a ("selftests: forwarding: Add layer 2 miss test cases")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
 .../selftests/net/forwarding/tc_flower_l2_miss.sh  | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Petr Machata June 12, 2023, 6:15 a.m. UTC | #1 
Ido Schimmel <idosch@nvidia.com> writes:

> The test currently specifies "l2_miss" as "true" / "false", but the
> version that eventually landed in iproute2 uses "1" / "0" [1]. Align the
> test accordingly.
>
> [1] https://lore.kernel.org/netdev/20230607153550.3829340-1-idosch@nvidia.com/
>
> Fixes: 8c33266ae26a ("selftests: forwarding: Add layer 2 miss test cases")
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>

Reviewed-by: Petr Machata <petrm@nvidia.com>
patchwork-bot+netdevbpf@kernel.org June 13, 2023, 8:40 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Sun, 11 Jun 2023 14:22:18 +0300 you wrote:
> The test currently specifies "l2_miss" as "true" / "false", but the
> version that eventually landed in iproute2 uses "1" / "0" [1]. Align the
> test accordingly.
> 
> [1] https://lore.kernel.org/netdev/20230607153550.3829340-1-idosch@nvidia.com/
> 
> Fixes: 8c33266ae26a ("selftests: forwarding: Add layer 2 miss test cases")
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: forwarding: Fix layer 2 miss test syntax
    https://git.kernel.org/netdev/net-next/c/c29e012eae29

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/forwarding/tc_flower_l2_miss.sh b/tools/testing/selftests/net/forwarding/tc_flower_l2_miss.sh
index 37b0369b5246..e22c2d28b6eb 100755
--- a/tools/testing/selftests/net/forwarding/tc_flower_l2_miss.sh
+++ b/tools/testing/selftests/net/forwarding/tc_flower_l2_miss.sh
@@ -78,11 +78,11 @@  test_l2_miss_unicast()
 
 	# Unknown unicast.
 	tc filter add dev $swp2 egress protocol ipv4 handle 101 pref 1 \
-	   flower indev $swp1 l2_miss true dst_mac $dmac src_ip $sip \
+	   flower indev $swp1 l2_miss 1 dst_mac $dmac src_ip $sip \
 	   dst_ip $dip action pass
 	# Known unicast.
 	tc filter add dev $swp2 egress protocol ipv4 handle 102 pref 1 \
-	   flower indev $swp1 l2_miss false dst_mac $dmac src_ip $sip \
+	   flower indev $swp1 l2_miss 0 dst_mac $dmac src_ip $sip \
 	   dst_ip $dip action pass
 
 	# Before adding FDB entry.
@@ -134,11 +134,11 @@  test_l2_miss_multicast_common()
 
 	# Unregistered multicast.
 	tc filter add dev $swp2 egress protocol $proto handle 101 pref 1 \
-	   flower indev $swp1 l2_miss true src_ip $sip dst_ip $dip \
+	   flower indev $swp1 l2_miss 1 src_ip $sip dst_ip $dip \
 	   action pass
 	# Registered multicast.
 	tc filter add dev $swp2 egress protocol $proto handle 102 pref 1 \
-	   flower indev $swp1 l2_miss false src_ip $sip dst_ip $dip \
+	   flower indev $swp1 l2_miss 0 src_ip $sip dst_ip $dip \
 	   action pass
 
 	# Before adding MDB entry.
@@ -245,7 +245,7 @@  test_l2_miss_ll_multicast_common()
 	RET=0
 
 	tc filter add dev $swp2 egress protocol $proto handle 101 pref 1 \
-	   flower indev $swp1 l2_miss true dst_mac $dmac src_ip $sip \
+	   flower indev $swp1 l2_miss 1 dst_mac $dmac src_ip $sip \
 	   dst_ip $dip action pass
 
 	$MZ $mode $h1 -a own -b $dmac -t ip -A $sip -B $dip -c 1 -p 100 -q
@@ -296,10 +296,10 @@  test_l2_miss_broadcast()
 	RET=0
 
 	tc filter add dev $swp2 egress protocol all handle 101 pref 1 \
-	   flower l2_miss true dst_mac $dmac src_mac $smac \
+	   flower l2_miss 1 dst_mac $dmac src_mac $smac \
 	   action pass
 	tc filter add dev $swp2 egress protocol all handle 102 pref 1 \
-	   flower l2_miss false dst_mac $dmac src_mac $smac \
+	   flower l2_miss 0 dst_mac $dmac src_mac $smac \
 	   action pass
 
 	$MZ $h1 -a $smac -b $dmac -c 1 -p 100 -q