diff mbox series

[v1] drivers:net:ethernet:remove repeating expression

Message ID 20230614131408.3097-1-machel@vivo.com (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series [v1] drivers:net:ethernet:remove repeating expression | expand

Checks

Context Check Description
netdev/tree_selection success Guessing tree name failed - patch did not apply

Commit Message

Wang Ming June 14, 2023, 1:13 p.m. UTC 
Identify issues that arise by using the tests/doublebitand.cocci
semantic patch.Need to remove duplicate expression in statement.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 -
 1 file changed, 1 deletion(-)

--
2.25.1

Comments

Pavan Chebbi June 14, 2023, 1:49 p.m. UTC | #1 
On Wed, Jun 14, 2023 at 6:45 PM Wang Ming <machel@vivo.com> wrote:
>
> Identify issues that arise by using the tests/doublebitand.cocci
> semantic patch.Need to remove duplicate expression in statement.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---

Please fix the patch format (subject) so that patch goes through
CI/sanity checks.
https://www.kernel.org/doc/html/v5.7/process/submitting-patches.html

>  drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 -
>  1 file changed, 1 deletion(-)
>
Wang Ming June 15, 2023, 2:18 a.m. UTC | #2 
Thanks, I will fix the patch format(subject).

-----邮件原件-----
发件人: Pavan Chebbi <pavan.chebbi@broadcom.com> 
发送时间: 2023年6月14日 21:49
收件人: 王明-软件底层技术部 <machel@vivo.com>
抄送: Jiawen Wu <jiawenwu@trustnetic.com>; Mengyuan Lou <mengyuanlou@net-swift.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Stephen Rothwell <sfr@canb.auug.org.au>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; opensource.kernel <opensource.kernel@vivo.com>
主题: Re: [PATCH v1] drivers:net:ethernet:remove repeating expression

On Wed, Jun 14, 2023 at 6:45 PM Wang Ming <machel@vivo.com> wrote:
>
> Identify issues that arise by using the tests/doublebitand.cocci
> semantic patch.Need to remove duplicate expression in statement.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---

Please fix the patch format (subject) so that patch goes through
CI/sanity checks.
https://www.kernel.org/doc/html/v5.7/process/submitting-patches.html

>  drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 -
>  1 file changed, 1 deletion(-)
>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
index 39a9aeee7..6321178fc 100644
--- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c
+++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
@@ -1511,7 +1511,6 @@  static void wx_configure_rx(struct wx *wx)
        psrtype = WX_RDB_PL_CFG_L4HDR |
                  WX_RDB_PL_CFG_L3HDR |
                  WX_RDB_PL_CFG_L2HDR |
-                 WX_RDB_PL_CFG_TUN_TUNHDR |
                  WX_RDB_PL_CFG_TUN_TUNHDR;
        wr32(wx, WX_RDB_PL_CFG(0), psrtype);