| Message ID | 20230614210656.6264-1-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 92717c2356cb62c89e8a3dc37cbbab2502562524 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [V2,net] net: qca_spi: Avoid high load if QCA7000 is not available | expand |
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Wed, 14 Jun 2023 23:06:56 +0200 you wrote: > In case the QCA7000 is not available via SPI (e.g. in reset), > the driver will cause a high load. The reason for this is > that the synchronization is never finished and schedule() > is never called. Since the synchronization is not timing > critical, it's safe to drop this from the scheduling condition. > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000") > > [...] Here is the summary with links: - [V2,net] net: qca_spi: Avoid high load if QCA7000 is not available https://git.kernel.org/netdev/net/c/92717c2356cb You are awesome, thank you!
diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index bba1947792ea16..90f18ea4c28ba1 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c @@ -582,8 +582,7 @@ qcaspi_spi_thread(void *data) while (!kthread_should_stop()) { set_current_state(TASK_INTERRUPTIBLE); if ((qca->intr_req == qca->intr_svc) && - (qca->txr.skb[qca->txr.head] == NULL) && - (qca->sync == QCASPI_SYNC_READY)) + !qca->txr.skb[qca->txr.head]) schedule(); set_current_state(TASK_RUNNING);
In case the QCA7000 is not available via SPI (e.g. in reset), the driver will cause a high load. The reason for this is that the synchronization is never finished and schedule() is never called. Since the synchronization is not timing critical, it's safe to drop this from the scheduling condition. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000") --- Changes in V2: - send from different account which doesn't break the patch drivers/net/ethernet/qualcomm/qca_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)