| Message ID | 20230615070512.6634-1-machel@vivo.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v1] drivers:net:dsa:Fix resource leaks in fwnode_for_each_child_node() loops | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
On Thu, Jun 15, 2023 at 03:04:58PM +0800, Wang Ming wrote: > The fwnode_for_each_child_node loop in qca8k_setup_led_ctrl should > have fwnode_handle_put() before return which could avoid resource leaks. > This patch could fix this bug. > > Signed-off-by: Wang Ming <machel@vivo.com> Hi Wang Ming, unfortunately your patch has been whitespace mangled - tabs have been converted into 8 spaces. Possibly this was done by your mail client or mail server. In any case the result is that the patch doesn't apply. And unfortunately that breaks our processes. Also, I'm assuming that as this patch is a fix, it is targeted at the "net", as opposed to "net-next", tree. This should be noted in the subject. Subject: [PATCH net v2] ... Lastly, looking at the git history of qca8k-leds.c, I think that a better prefix for the patch is "net: dsa: qca8k: ". Subject: [PATCH net v2] net: dsa: qca8k: ... Please consider addressing the problems and reposting your patch.
Hi Simon, On Thu, Jun 15, 2023 at 03:03:15PM +0200, Simon Horman wrote: > On Thu, Jun 15, 2023 at 03:04:58PM +0800, Wang Ming wrote: > > The fwnode_for_each_child_node loop in qca8k_setup_led_ctrl should > > have fwnode_handle_put() before return which could avoid resource leaks. > > This patch could fix this bug. > > > > Signed-off-by: Wang Ming <machel@vivo.com> > > Hi Wang Ming, > > unfortunately your patch has been whitespace mangled - tabs have been > converted into 8 spaces. Possibly this was done by your mail client > or mail server. In any case the result is that the patch doesn't apply. > And unfortunately that breaks our processes. > > Also, I'm assuming that as this patch is a fix, it is targeted at the > "net", as opposed to "net-next", tree. This should be noted in the subject. > > Subject: [PATCH net v2] ... > > Lastly, looking at the git history of qca8k-leds.c, I think that > a better prefix for the patch is "net: dsa: qca8k: ". > > Subject: [PATCH net v2] net: dsa: qca8k: ... > > Please consider addressing the problems and reposting your patch. > > -- > pw-bot: changes-requested I think that according to the disclaimer text, you as a subscriber to the mailing list should have deleted this message instead of commenting on it :) | The contents of this message and any attachments may contain confidential | and/or privileged information and are intended exclusively for the | addressee(s). If you are not the intended recipient of this message or | their agent, please note that any use, dissemination, copying, or storage | of this message or its attachments is not allowed. | If you receive this message in error, please notify the sender by reply | the message or phone and delete this message, any attachments and any | copies immediately. Seriously now, that has to go when posting to a mailing list whose archives can be seen on the world wide web. https://lore.kernel.org/netdev/20230615070512.6634-1-machel@vivo.com/ 2 comments from my side on the actual patch. 1. There is an indentation of 1 space in the commit message which doesn't belong there. 2. I believe that the "ports" fwnode_handle is also leaked, both in the error as well as in the success case. And one more process-related observation. You must find the commit which introduced the problem and add: Fixes: 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support") and also CC the author of that patch.
Okay，thank you ,I will do as you suggest. -----邮件原件----- 发件人: Vladimir Oltean <olteanv@gmail.com> 发送时间: 2023年6月16日 4:37 收件人: Simon Horman <simon.horman@corigine.com> 抄送: 王明-软件底层技术部 <machel@vivo.com>; Andrew Lunn <andrew@lunn.ch>; Florian Fainelli <f.fainelli@gmail.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Stephen Rothwell <sfr@canb.auug.org.au>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; opensource.kernel <opensource.kernel@vivo.com> 主题: Re: [PATCH v1] drivers:net:dsa:Fix resource leaks in fwnode_for_each_child_node() loops Hi Simon, On Thu, Jun 15, 2023 at 03:03:15PM +0200, Simon Horman wrote: > On Thu, Jun 15, 2023 at 03:04:58PM +0800, Wang Ming wrote: > > The fwnode_for_each_child_node loop in qca8k_setup_led_ctrl should > > have fwnode_handle_put() before return which could avoid resource leaks. > > This patch could fix this bug. > > > > Signed-off-by: Wang Ming <machel@vivo.com> > > Hi Wang Ming, > > unfortunately your patch has been whitespace mangled - tabs have been > converted into 8 spaces. Possibly this was done by your mail client or > mail server. In any case the result is that the patch doesn't apply. > And unfortunately that breaks our processes. > > Also, I'm assuming that as this patch is a fix, it is targeted at the > "net", as opposed to "net-next", tree. This should be noted in the subject. > > Subject: [PATCH net v2] ... > > Lastly, looking at the git history of qca8k-leds.c, I think that a > better prefix for the patch is "net: dsa: qca8k: ". > > Subject: [PATCH net v2] net: dsa: qca8k: ... > > Please consider addressing the problems and reposting your patch. > > -- > pw-bot: changes-requested I think that according to the disclaimer text, you as a subscriber to the mailing list should have deleted this message instead of commenting on it :) | The contents of this message and any attachments may contain | confidential and/or privileged information and are intended | exclusively for the addressee(s). If you are not the intended | recipient of this message or their agent, please note that any use, | dissemination, copying, or storage of this message or its attachments is not allowed. | If you receive this message in error, please notify the sender by | reply the message or phone and delete this message, any attachments | and any copies immediately. Seriously now, that has to go when posting to a mailing list whose archives can be seen on the world wide web. https://lore.kernel.org/netdev/20230615070512.6634-1-machel@vivo.com/ 2 comments from my side on the actual patch. 1. There is an indentation of 1 space in the commit message which doesn't belong there. 2. I believe that the "ports" fwnode_handle is also leaked, both in the error as well as in the success case. And one more process-related observation. You must find the commit which introduced the problem and add: Fixes: 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support") and also CC the author of that patch.
On Fri, Jun 16, 2023 at 01:36:43AM +0000, 王明-软件底层技术部 wrote:
> Okay，thank you ,I will do as you suggest.
And because that patch is in net-next.git and not (yet) in net.git, the
prefix should be "[PATCH v2 net-next]".
Ok，thank you, I see.
-----邮件原件-----
发件人: Vladimir Oltean <olteanv@gmail.com>
发送时间: 2023年6月16日 16:58
收件人: 王明-软件底层技术部 <machel@vivo.com>
抄送: Andrew Lunn <andrew@lunn.ch>; Florian Fainelli <f.fainelli@gmail.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Stephen Rothwell <sfr@canb.auug.org.au>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; opensource.kernel <opensource.kernel@vivo.com>
主题: Re: 回复: [PATCH v1] drivers:net:dsa:Fix resource leaks in fwnode_for_each_child_node() loops
On Fri, Jun 16, 2023 at 01:36:43AM +0000, 王明-软件底层技术部 wrote:
> Okay，thank you ,I will do as you suggest.
And because that patch is in net-next.git and not (yet) in net.git, the prefix should be "[PATCH v2 net-next]".
diff --git a/drivers/net/dsa/qca/qca8k-leds.c b/drivers/net/dsa/qca/qca8k-leds.c index 6f02029b4..d24ee5df9 100644 --- a/drivers/net/dsa/qca/qca8k-leds.c +++ b/drivers/net/dsa/qca/qca8k-leds.c @@ -450,8 +450,10 @@ qca8k_setup_led_ctrl(struct qca8k_priv *priv) * the correct port for LED setup. */ ret = qca8k_parse_port_leds(priv, port, qca8k_port_to_phy(port_num)); - if (ret) + if (ret) { + fwnode_handle_put(port); return ret; + } } return 0;
The fwnode_for_each_child_node loop in qca8k_setup_led_ctrl should have fwnode_handle_put() before return which could avoid resource leaks. This patch could fix this bug. Signed-off-by: Wang Ming <machel@vivo.com> --- drivers/net/dsa/qca/qca8k-leds.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.25.1