| Message ID | 20230620144855.288443-1-ivecera@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7ad7b7023fcb1efdd71406ff7670ef6130de65a6 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] bnxt_en: Link representors to PCI device | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Single patches do not need cover letters |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 8 this patch: 8 |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/build_clang | success | Errors and warnings before: 8 this patch: 8 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 8 this patch: 8 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Tue, Jun 20, 2023 at 04:48:55PM +0200, Ivan Vecera wrote: > Link VF representors to parent PCI device to benefit from > systemd defined naming scheme. > > Without this change the representor is visible as ethN. > > Signed-off-by: Ivan Vecera <ivecera@redhat.com> Reviewed-by: Simon Horman <simon.horman@corigine.com>
On Tue, Jun 20, 2023 at 10:00 PM Ivan Vecera <ivecera@redhat.com> wrote: > > Link VF representors to parent PCI device to benefit from > systemd defined naming scheme. > > Without this change the representor is visible as ethN. > > Signed-off-by: Ivan Vecera <ivecera@redhat.com> Acked-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> > --- > drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c > index 2f1a1f2d2157..1467b94a6427 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c > @@ -468,6 +468,7 @@ static void bnxt_vf_rep_netdev_init(struct bnxt *bp, struct bnxt_vf_rep *vf_rep, > struct net_device *pf_dev = bp->dev; > u16 max_mtu; > > + SET_NETDEV_DEV(dev, &bp->pdev->dev); > dev->netdev_ops = &bnxt_vf_rep_netdev_ops; > dev->ethtool_ops = &bnxt_vf_rep_ethtool_ops; > /* Just inherit all the featues of the parent PF as the VF-R > -- > 2.39.3 > >
On Tue, 20 Jun 2023 22:19:32 +0530 Sriharsha Basavapatna wrote: > This electronic communication and the information and any files transmitted > with it, or attached to it, are confidential and are intended solely for > the use of the individual or entity to whom it is addressed and may contain > information that is confidential, legally privileged, protected by privacy > laws, or otherwise restricted from disclosure to anyone else. If you are > not the intended recipient or the person responsible for delivering the > e-mail to the intended recipient, you are hereby notified that any use, > copying, distributing, dissemination, forwarding, printing, or copying of > this e-mail is strictly prohibited. If you received this e-mail in error, > please return the e-mail to the sender, delete it from your computer, and > destroy any printed copy of it. Your emails to the list must not include any legal note of this nature. I'll have to manually delete your review tag from the system.
On Tue, Jun 20, 2023 at 7:52 AM Ivan Vecera <ivecera@redhat.com> wrote: > > Link VF representors to parent PCI device to benefit from > systemd defined naming scheme. > > Without this change the representor is visible as ethN. > > Signed-off-by: Ivan Vecera <ivecera@redhat.com> Thanks. Reviewed-by: Michael Chan <michael.chan@broadcon.com>
On Tue, Jun 20, 2023 at 10:26:21AM -0700, Michael Chan wrote: > On Tue, Jun 20, 2023 at 7:52 AM Ivan Vecera <ivecera@redhat.com> wrote: > > > > Link VF representors to parent PCI device to benefit from > > systemd defined naming scheme. > > > > Without this change the representor is visible as ethN. > > > > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > > Thanks. > > Reviewed-by: Michael Chan <michael.chan@broadcon.com> nit:) broadcon -> broadcom
On Tue, Jun 20, 2023 at 12:41 PM Simon Horman <simon.horman@corigine.com> wrote: > > On Tue, Jun 20, 2023 at 10:26:21AM -0700, Michael Chan wrote: > > On Tue, Jun 20, 2023 at 7:52 AM Ivan Vecera <ivecera@redhat.com> wrote: > > > > > > Link VF representors to parent PCI device to benefit from > > > systemd defined naming scheme. > > > > > > Without this change the representor is visible as ethN. > > > > > > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > > > > Thanks. > > > > Reviewed-by: Michael Chan <michael.chan@broadcon.com> > > nit:) broadcon -> broadcom > > Typo fixed. Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 20 Jun 2023 16:48:55 +0200 you wrote: > Link VF representors to parent PCI device to benefit from > systemd defined naming scheme. > > Without this change the representor is visible as ethN. > > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > > [...] Here is the summary with links: - [net-next] bnxt_en: Link representors to PCI device https://git.kernel.org/netdev/net-next/c/7ad7b7023fcb You are awesome, thank you!
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c index 2f1a1f2d2157..1467b94a6427 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c @@ -468,6 +468,7 @@ static void bnxt_vf_rep_netdev_init(struct bnxt *bp, struct bnxt_vf_rep *vf_rep, struct net_device *pf_dev = bp->dev; u16 max_mtu; + SET_NETDEV_DEV(dev, &bp->pdev->dev); dev->netdev_ops = &bnxt_vf_rep_netdev_ops; dev->ethtool_ops = &bnxt_vf_rep_ethtool_ops; /* Just inherit all the featues of the parent PF as the VF-R
Link VF representors to parent PCI device to benefit from systemd defined naming scheme. Without this change the representor is visible as ethN. Signed-off-by: Ivan Vecera <ivecera@redhat.com> --- drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 1 + 1 file changed, 1 insertion(+)