diff mbox series

[2/3] net: phy: at803x: remove 1000BaseX mode of qca8081

Message ID 20230629034846.30600-3-quic_luoj@quicinc.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series net: phy: at803x: support qca8081 1G version chip | expand

Checks

Context Check Description
netdev/series_format warning Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/cc_maintainers success CCed 8 of 8 maintainers
netdev/build_clang fail Errors and warnings before: 18 this patch: 18
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch warning WARNING: line length of 91 exceeds 80 columns
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Luo Jie June 29, 2023, 3:48 a.m. UTC
QCA808x does not support the link mode 1000BaseX.

Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
---
 drivers/net/phy/at803x.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Andrew Lunn June 29, 2023, 1:16 p.m. UTC | #1
On Thu, Jun 29, 2023 at 11:48:45AM +0800, Luo Jie wrote:
> QCA808x does not support the link mode 1000BaseX.
> 
> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
diff mbox series

Patch

diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 3339ca372b24..29aab7eaaa90 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -920,7 +920,7 @@  static int at803x_get_features(struct phy_device *phydev)
 		}
 	}
 
-	if (phydev->drv->phy_id != ATH8031_PHY_ID)
+	if (phydev->drv->phy_id != ATH8031_PHY_ID && phydev->drv->phy_id != QCA8081_PHY_ID)
 		return 0;
 
 	/* AR8031/AR8033 have different status registers
@@ -933,6 +933,8 @@  static int at803x_get_features(struct phy_device *phydev)
 	 *
 	 * Remove this mode from the supported link modes
 	 * when not operating in 1000BaseX mode.
+	 *
+	 * QCA808x does not support 1000BaseX mode.
 	 */
 	if (!priv->is_1000basex)
 		linkmode_clear_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT,