| Message ID | 20230708-lan743x-fixed-phy-v1-1-3fd19580546c@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 73c4d1b307aeb713e80ab03f90c7df9d417dc0f0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: lan743x: select FIXED_PHY | expand |
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Sat, 08 Jul 2023 15:06:25 +0100 you wrote: > The blamed commit introduces usage of fixed_phy_register() but > not a corresponding dependency on FIXED_PHY. > > This can result in a build failure. > > s390-linux-ld: drivers/net/ethernet/microchip/lan743x_main.o: in function `lan743x_phy_open': > drivers/net/ethernet/microchip/lan743x_main.c:1514: undefined reference to `fixed_phy_register' > > [...] Here is the summary with links: - [net] net: lan743x: select FIXED_PHY https://git.kernel.org/netdev/net/c/73c4d1b307ae You are awesome, thank you!
diff --git a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig index 24c994baad13..329e374b9539 100644 --- a/drivers/net/ethernet/microchip/Kconfig +++ b/drivers/net/ethernet/microchip/Kconfig @@ -46,7 +46,7 @@ config LAN743X tristate "LAN743x support" depends on PCI depends on PTP_1588_CLOCK_OPTIONAL - select PHYLIB + select FIXED_PHY select CRC16 select CRC32 help
The blamed commit introduces usage of fixed_phy_register() but not a corresponding dependency on FIXED_PHY. This can result in a build failure. s390-linux-ld: drivers/net/ethernet/microchip/lan743x_main.o: in function `lan743x_phy_open': drivers/net/ethernet/microchip/lan743x_main.c:1514: undefined reference to `fixed_phy_register' Fixes: 624864fbff92 ("net: lan743x: add fixed phy support for LAN7431 device") Cc: stable@vger.kernel.org Reported-by: Randy Dunlap <rdunlap@infradead.org> Closes: https://lore.kernel.org/netdev/725bf1c5-b252-7d19-7582-a6809716c7d6@infradead.org/ Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Signed-off-by: Simon Horman <horms@kernel.org> --- drivers/net/ethernet/microchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)