| Message ID | 20230708082958.1597850-1-edumazet@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 51d03e2f2203e76ed02d33fb5ffbb5fc85ffaf54 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] udp6: fix udp6_ehashfn() typo | expand |
Eric Dumazet wrote: > Amit Klein reported that udp6_ehash_secret was initialized but never used. > > Fixes: 1bbdceef1e53 ("inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once") > Reported-by: Amit Klein <aksecurity@gmail.com> > Signed-off-by: Eric Dumazet <edumazet@google.com> > Cc: Willy Tarreau <w@1wt.eu> > Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com> > Cc: David Ahern <dsahern@kernel.org> > Cc: Hannes Frederic Sowa <hannes@stressinduktion.org> Reviewed-by: Willem de Bruijn <willemb@google.com>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Sat, 8 Jul 2023 08:29:58 +0000 you wrote: > Amit Klein reported that udp6_ehash_secret was initialized but never used. > > Fixes: 1bbdceef1e53 ("inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once") > Reported-by: Amit Klein <aksecurity@gmail.com> > Signed-off-by: Eric Dumazet <edumazet@google.com> > Cc: Willy Tarreau <w@1wt.eu> > Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com> > Cc: David Ahern <dsahern@kernel.org> > Cc: Hannes Frederic Sowa <hannes@stressinduktion.org> > > [...] Here is the summary with links: - [net] udp6: fix udp6_ehashfn() typo https://git.kernel.org/netdev/net/c/51d03e2f2203 You are awesome, thank you!
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index 630d61a32c1df0bc222dfff2613585b2d416f839..b7c972aa09a75404e0edb33f0354c53702c991f8 100644 --- a/net/ipv6/udp.c +++ b/net/ipv6/udp.c @@ -91,7 +91,7 @@ static u32 udp6_ehashfn(const struct net *net, fhash = __ipv6_addr_jhash(faddr, udp_ipv6_hash_secret); return __inet6_ehashfn(lhash, lport, fhash, fport, - udp_ipv6_hash_secret + net_hash_mix(net)); + udp6_ehash_secret + net_hash_mix(net)); } int udp_v6_get_port(struct sock *sk, unsigned short snum)
Amit Klein reported that udp6_ehash_secret was initialized but never used. Fixes: 1bbdceef1e53 ("inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once") Reported-by: Amit Klein <aksecurity@gmail.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Willy Tarreau <w@1wt.eu> Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com> Cc: David Ahern <dsahern@kernel.org> Cc: Hannes Frederic Sowa <hannes@stressinduktion.org> --- net/ipv6/udp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)