| Message ID | 20230710031859.36784-1-luhongfei@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 04499f28b40bfc24f20b0e2331008bb90a54a6cf |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: Removed unneeded of_node_put in felix_parse_ports_node | expand |
On Mon, Jul 10, 2023 at 11:18:59AM +0800, Lu Hongfei wrote: > Remove unnecessary of_node_put from the continue path to prevent > child node from being released twice, which could avoid resource > leak or other unexpected issues. > > Signed-off-by: Lu Hongfei <luhongfei@vivo.com> > --- > drivers/net/dsa/ocelot/felix.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c > index dee43caee19e..8da46d284e35 100644 > --- a/drivers/net/dsa/ocelot/felix.c > +++ b/drivers/net/dsa/ocelot/felix.c > @@ -1286,7 +1286,6 @@ static int felix_parse_ports_node(struct felix *felix, > if (err < 0) { > dev_info(dev, "Unsupported PHY mode %s on port %d\n", > phy_modes(phy_mode), port); > - of_node_put(child); > > /* Leave port_phy_modes[port] = 0, which is also > * PHY_INTERFACE_MODE_NA. This will perform a > -- > 2.39.0 > Fixes: de879a016a94 ("net: dsa: felix: add functionality when not all ports are supported") Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Mon, 10 Jul 2023 11:18:59 +0800 you wrote: > Remove unnecessary of_node_put from the continue path to prevent > child node from being released twice, which could avoid resource > leak or other unexpected issues. > > Signed-off-by: Lu Hongfei <luhongfei@vivo.com> > --- > drivers/net/dsa/ocelot/felix.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - net: dsa: Removed unneeded of_node_put in felix_parse_ports_node https://git.kernel.org/netdev/net/c/04499f28b40b You are awesome, thank you!
diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c index dee43caee19e..8da46d284e35 100644 --- a/drivers/net/dsa/ocelot/felix.c +++ b/drivers/net/dsa/ocelot/felix.c @@ -1286,7 +1286,6 @@ static int felix_parse_ports_node(struct felix *felix, if (err < 0) { dev_info(dev, "Unsupported PHY mode %s on port %d\n", phy_modes(phy_mode), port); - of_node_put(child); /* Leave port_phy_modes[port] = 0, which is also * PHY_INTERFACE_MODE_NA. This will perform a
Remove unnecessary of_node_put from the continue path to prevent child node from being released twice, which could avoid resource leak or other unexpected issues. Signed-off-by: Lu Hongfei <luhongfei@vivo.com> --- drivers/net/dsa/ocelot/felix.c | 1 - 1 file changed, 1 deletion(-)